From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH v4 7/9] mfd: ioc3: Add driver for SGI IOC3 chip Date: Mon, 12 Aug 2019 12:52:02 -0700 Message-ID: <20190812125202.46608b74@cakuba.netronome.com> References: <20190809103235.16338-1-tbogendoerfer@suse.de> <20190809103235.16338-8-tbogendoerfer@suse.de> <20190809142222.4558691e@cakuba.netronome.com> <20190811093212.88635fb1a6c796a073ec71ff@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190811093212.88635fb1a6c796a073ec71ff@suse.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Bogendoerfer Cc: Ralf Baechle , Paul Burton , James Hogan , Dmitry Torokhov , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Evgeniy Polyakov , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org List-Id: linux-input@vger.kernel.org On Sun, 11 Aug 2019 09:32:12 +0200, Thomas Bogendoerfer wrote: > > Also please don't use stdint types in the kernel, please try checkpatch > > to catch coding style issues. > > my patch already reduces them and checkpatch only warns about usage of printk > for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't > seem the right thing to do. As I'm splitting the conversion patch into a few > steps I could also replace the printks. Thanks for looking into it. I was referring to the use of uint32_t instead of u32. Perhaps checkpatch has to be motivated with the --strict option to point those out?