linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: uhid: actually use the err number from userspace
@ 2019-08-12 16:21 Benjamin Tissoires
  2019-08-13 10:49 ` David Rheinsberg
  0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Tissoires @ 2019-08-12 16:21 UTC (permalink / raw)
  To: David Rheinsberg, Jiri Kosina
  Cc: linux-input, linux-kernel, Benjamin Tissoires

This can help debugging the situation

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---

Hi,

not entirely sure if we can use this in a such simple way.

However, this is useful to mimic device behaviour from userspace.

Cheers,
Benjamin

 drivers/hid/uhid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
index fa0cc0899827..2fa32e7fc733 100644
--- a/drivers/hid/uhid.c
+++ b/drivers/hid/uhid.c
@@ -284,7 +284,7 @@ static int uhid_hid_set_report(struct hid_device *hid, unsigned char rnum,
 		goto unlock;
 
 	if (uhid->report_buf.u.set_report_reply.err)
-		ret = -EIO;
+		ret = -uhid->report_buf.u.set_report_reply.err;
 	else
 		ret = count;
 
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-14  8:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-12 16:21 [PATCH] HID: uhid: actually use the err number from userspace Benjamin Tissoires
2019-08-13 10:49 ` David Rheinsberg
2019-08-13 13:58   ` Benjamin Tissoires
2019-08-14  8:30     ` David Rheinsberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).