From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v5 15/17] mfd: ioc3: Add driver for SGI IOC3 chip Date: Tue, 20 Aug 2019 08:23:08 +0200 Message-ID: <20190820062308.GK3545@piout.net> References: <20190819163144.3478-1-tbogendoerfer@suse.de> <20190819163144.3478-16-tbogendoerfer@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190819163144.3478-16-tbogendoerfer@suse.de> Sender: netdev-owner@vger.kernel.org To: Thomas Bogendoerfer Cc: Jonathan Corbet , Ralf Baechle , Paul Burton , James Hogan , Dmitry Torokhov , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Greg Kroah-Hartman , Jiri Slaby , Evgeniy Polyakov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org List-Id: linux-input@vger.kernel.org Hi, On 19/08/2019 18:31:38+0200, Thomas Bogendoerfer wrote: > diff --git a/drivers/mfd/ioc3.c b/drivers/mfd/ioc3.c > new file mode 100644 > index 000000000000..5bcb3461a189 > --- /dev/null > +++ b/drivers/mfd/ioc3.c > @@ -0,0 +1,586 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SGI IOC3 multifunction device driver > + * > + * Copyright (C) 2018, 2019 Thomas Bogendoerfer > + * > + * Based on work by: > + * Stanislaw Skowronek > + * Joshua Kinard > + * Brent Casavant - IOC4 master driver > + * Pat Gefre - IOC3 serial port IRQ demuxer > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I don't think this include is necessary. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com