From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: bgoswami@codeaurora.org
Cc: alsa-devel@alsa-project.org, plai@codeaurora.org, tiwai@suse.com,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
linux-input@vger.kernel.org,
Gopikrishnaiah Anandan <agopik@codeaurora.org>
Subject: Re: [PATCH 2/3] input: Add SW_UNSUPPORT_INSERT define
Date: Thu, 22 Aug 2019 11:16:19 -0700 [thread overview]
Message-ID: <20190822181619.GH76194@dtor-ws> (raw)
In-Reply-To: <1558730438-16524-1-git-send-email-bgoswami@codeaurora.org>
Hi Banajit,
On Fri, May 24, 2019 at 01:40:38PM -0700, bgoswami@codeaurora.org wrote:
> From: Banajit Goswami <bgoswami@codeaurora.org>
>
> Some devices may not support specific type of input devices. For example,
> when a headset or extension cable with GND/MIC swap is plugged into a
> headset jack that does not support the headset/cable, it needs to be
> reported with a corresponding input event. Also, increase the max values
> for INPUT_DEVICE_ID_SW_MAX and SW_MAX, to accommodate future extension of
> the number of event.
I do not think that adding this switch is a good idea as it will not
allow you to easily extend the reporting and to convey to the user why
something is not supported. I would look into alternate mechanism to
signal when and why a headset/peripheral was rejected.
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-08-22 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 20:40 [PATCH 2/3] input: Add SW_UNSUPPORT_INSERT define bgoswami
2019-08-22 18:16 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822181619.GH76194@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=agopik@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).