From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 2/3] input: Add SW_UNSUPPORT_INSERT define Date: Thu, 22 Aug 2019 11:16:19 -0700 Message-ID: <20190822181619.GH76194@dtor-ws> References: <1558730438-16524-1-git-send-email-bgoswami@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1558730438-16524-1-git-send-email-bgoswami@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: bgoswami@codeaurora.org Cc: alsa-devel@alsa-project.org, plai@codeaurora.org, tiwai@suse.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, linux-input@vger.kernel.org, Gopikrishnaiah Anandan List-Id: linux-input@vger.kernel.org Hi Banajit, On Fri, May 24, 2019 at 01:40:38PM -0700, bgoswami@codeaurora.org wrote: > From: Banajit Goswami > > Some devices may not support specific type of input devices. For example, > when a headset or extension cable with GND/MIC swap is plugged into a > headset jack that does not support the headset/cable, it needs to be > reported with a corresponding input event. Also, increase the max values > for INPUT_DEVICE_ID_SW_MAX and SW_MAX, to accommodate future extension of > the number of event. I do not think that adding this switch is a good idea as it will not allow you to easily extend the reporting and to convey to the user why something is not supported. I would look into alternate mechanism to signal when and why a headset/peripheral was rejected. Thanks. -- Dmitry