From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1182BC35280 for ; Wed, 2 Oct 2019 15:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCBAC222BE for ; Wed, 2 Oct 2019 15:18:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="niLLx97Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbfJBPSS (ORCPT ); Wed, 2 Oct 2019 11:18:18 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:53308 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727498AbfJBPSR (ORCPT ); Wed, 2 Oct 2019 11:18:17 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x92FHqu7121321; Wed, 2 Oct 2019 10:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570029472; bh=XdNPQjDWDIANjxFkYVhRetRjSoQQX2NhBQD1Yjc+BQw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=niLLx97YsloDYxsLEY2Ee34kmRfx0AUfa12xUKAEwRb1DBtOrM/heORSb7lERCqdS jFSj/6F1INcoFPinQA20t76QJUbwd7hA406B70FpxxzHxplK8uzNGgR/oEXvAeIVtb A3Q5mdbBfLz70v4XCRseSRueRqeUCkTeKkN8UHL8= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id x92FHqmC068960; Wed, 2 Oct 2019 10:17:52 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 2 Oct 2019 10:17:41 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 2 Oct 2019 10:17:41 -0500 Received: from ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with SMTP id x92FHpAo044680; Wed, 2 Oct 2019 10:17:51 -0500 Date: Wed, 2 Oct 2019 10:20:03 -0500 From: Benoit Parrot To: Marco Felsch CC: Rob Herring , Dmitry Torokhov , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation Message-ID: <20191002152003.ag36lrragazsdn5j@ti.com> References: <20190917155808.27818-1-m.felsch@pengutronix.de> <20190917155808.27818-3-m.felsch@pengutronix.de> <20190917170743.GO237523@dtor-ws> <20190917171814.owcttekv56xgmsts@pengutronix.de> <20190917172658.GQ237523@dtor-ws> <20190930231146.GA30010@bogus> <20191002130018.pvgipl6bkcv3dexj@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20191002130018.pvgipl6bkcv3dexj@pengutronix.de> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Marco Felsch wrote on Wed [2019-Oct-02 15:00:18 +0200]: > Hi, > > all of you using a edt,* touchscreen and currently the driver marks > the touchscreen as wakeup source. To keep backward compatibility I added > a workaround binding (see below) but Dmitry prefer to use the normal > "wakeup-source" binding and change the affected device-tree's > (discussion below). Can you give me your ack/nack for Dmitry's solution? So, if I understand this correctly, currently the driver always assume it is a wakeup source regardless if the "wakeup-source" DT property being present or not. And the proposed change now is to fix the driver so that it will assume a wakeup source role only if the DT property is present? If that is the case then ACK from my side for the AM43x devices. Regards, Benoit > > Regards, > Marco >