From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Michal Vokáč" <michal.vokac@ysoft.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: input: Convert mpr121 binding to json-schema
Date: Tue, 15 Oct 2019 17:24:01 -0700 [thread overview]
Message-ID: <20191016002401.GL105649@dtor-ws> (raw)
In-Reply-To: <20191010193651.GA16598@bogus>
On Thu, Oct 10, 2019 at 02:36:51PM -0500, Rob Herring wrote:
> On Thu, 3 Oct 2019 08:12:53 +0200, =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= wrote:
> > Convert the mpr121 binding to DT schema format using json-schema.
> >
> > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> > ---
> > Changes since v2:
> > - None
> >
> > Changes since v1:
> > - Extract the common input properties into the input.yaml schema.
> > - Fix the wakeup-source description.
> > - Fix the example to pass validation. Put the mpr121 device sub-node
> > into a i2c {} node.
> >
> > The linux,keycodes property is not valid as it is. If I put the minItems
> > and maxItems into the common schema, it is valid and the min/max length
> > check works fine. Rob, could you advice how to fix this please?
> >
> > The error is not very specific..
> >
> > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
> > SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
> > /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml: ignoring, error in schema 'linux,ke
> > warning: no schema found in file: /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
> > /home/vokac/development/sources/linux-fslc/Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/p
> > make[3]: *** [Documentation/devicetree/bindings/processed-schema.yaml] Error 255
> > /home/vokac/development/sources/linux-fslc/Makefile:1264: recipe for target 'dt_binding_check' failed
> >
> > .../bindings/input/fsl,mpr121-touchkey.yaml | 66 ++++++++++++++++++++++
> > .../devicetree/bindings/input/mpr121-touchkey.txt | 30 ----------
> > 2 files changed, 66 insertions(+), 30 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
> > delete mode 100644 Documentation/devicetree/bindings/input/mpr121-touchkey.txt
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2019-10-16 0:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 6:12 [PATCH v3 0/5] Add polling mode to the MPR121 touchkey Michal Vokáč
2019-10-03 6:12 ` [PATCH v3 1/5] dt-bindings: input: Add common input binding in json-schema Michal Vokáč
2019-10-10 19:35 ` Rob Herring
2019-10-16 0:23 ` Dmitry Torokhov
2019-10-03 6:12 ` [PATCH v3 2/5] dt-bindings: input: Convert mpr121 binding to json-schema Michal Vokáč
2019-10-04 13:58 ` Michal Vokáč
2019-10-10 19:36 ` Rob Herring
2019-10-16 0:24 ` Dmitry Torokhov [this message]
2019-10-03 6:12 ` [PATCH v3 3/5] dt-bindings: input: Add poll-interval property Michal Vokáč
2019-10-10 19:40 ` Rob Herring
2019-10-10 20:01 ` Dmitry Torokhov
2019-10-11 8:03 ` Michal Vokáč
2019-10-16 0:23 ` Dmitry Torokhov
2019-10-16 5:52 ` Michal Vokáč
2019-10-03 6:12 ` [PATCH v3 4/5] Input: mpr121: Add polling mode Michal Vokáč
2019-10-16 0:24 ` Dmitry Torokhov
2019-10-03 6:12 ` [PATCH v3 5/5] ARM: dts: imx6dl-yapp4: Enable the MPR121 touchkey controller on Hydra Michal Vokáč
2019-10-16 6:07 ` Michal Vokáč
2019-10-25 2:48 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016002401.GL105649@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).