linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] input: edt-ft5x06 - add polled input support
Date: Thu, 17 Oct 2019 11:03:23 -0700	[thread overview]
Message-ID: <20191017180323.GJ35946@dtor-ws> (raw)
In-Reply-To: <f029cb51eb99b9a51743b87cb736ec66e8ec0ae5.camel@suse.de>

Hi Nicolas,

On Wed, Jun 12, 2019 at 01:57:46PM +0200, Nicolas Saenz Julienne wrote:
> On Tue, 2019-04-30 at 20:58 +0200, Nicolas Saenz Julienne wrote:
> > Some hardware configurations might pass on providing an interrupt line.
> > In that case there is always the option to use a polled input approach.
> > This patch adapts the driver for it.
> > 
> > The polled approach is only triggered if no interrupt is provided by the
> > firmware or platform data.
> > 
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > ---
> 
> Ping :)

I reworked the polling in input devices so we no longer need to create a
separate input_polled_dev instances and instead have regular input
device work in polled mode by calling

	error = input_setup_polling(input_dev, poll_fn);
	...

Please adjust your patch and resubmit.

Thanks.

-- 
Dmitry

      reply	other threads:[~2019-10-17 18:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 18:58 [PATCH 1/2] input: edt-ft5x06 - add polled input support Nicolas Saenz Julienne
2019-04-30 18:58 ` [PATCH 2/2] Input: edt-ft5x06 - add support for polled configuration Nicolas Saenz Julienne
2019-05-02 21:32   ` Rob Herring
2019-06-12 11:57 ` [PATCH 1/2] input: edt-ft5x06 - add polled input support Nicolas Saenz Julienne
2019-10-17 18:03   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017180323.GJ35946@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsaenzjulienne@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).