From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc: robh@kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: touchscreen: Add NULL pointer check before dereference
Date: Fri, 25 Oct 2019 14:17:58 -0700 [thread overview]
Message-ID: <20191025211758.GC163068@dtor-ws> (raw)
In-Reply-To: <20191024180822.GA6408@SD>
Hi Saiyam,
On Thu, Oct 24, 2019 at 11:38:22PM +0530, Saiyam Doshi wrote:
> On Sun, Sep 01, 2019 at 11:53:09PM +0530, Saiyam Doshi wrote:
> > In sx8654_probe function, if call to device_get_match_data()
> > return NULL, it dereferences driver_data from 'id'.
> >
> > To avoid NULL pointer dereference, add check to make sure
> > 'id' is not NULL.
>
> Any review / update on this?
Can you please explain under what circumstances we can get NULL from
device_get_match_data() in this driver?
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-10-25 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190901182309.GA5574@ahmlpt0706>
2019-10-24 18:08 ` [PATCH] input: touchscreen: Add NULL pointer check before dereference Saiyam Doshi
2019-10-25 21:17 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025211758.GC163068@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saiyamdoshi.in@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).