From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9A0CA9EC2 for ; Tue, 29 Oct 2019 07:22:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C7D12086D for ; Tue, 29 Oct 2019 07:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728950AbfJ2HWl (ORCPT ); Tue, 29 Oct 2019 03:22:41 -0400 Received: from esa1.mentor.iphmx.com ([68.232.129.153]:7825 "EHLO esa1.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733089AbfJ2HWj (ORCPT ); Tue, 29 Oct 2019 03:22:39 -0400 IronPort-SDR: Sl/VArKq1YiPmM3imuOplizLMqUwkx3Ks/AMQhKXdnuS1RqDJUCpuLZKJs6TaEZiXoRx+xSram WkvjB2s0EYy5p03T9/1+euNZ7xdPt47f5/sMBs7XnTthrXvoLMcaDufvgt2VzHy1yIaOLY2sgx b2rImnnVqtFNnt8YP8U8BV2zJlnCqiB8C+t8gmTsFU+kq7AQDbkh8BZhUu5jcMjOq7kNGB/RKt hdh7ZdYhOAPqb5CuZOmicvnhnDp7sdiBSio9dKDPf1Xlleh4WsGpkv+nOk+tdWyGAgbSvK5B+M qhg= X-IronPort-AV: E=Sophos;i="5.68,243,1569312000"; d="scan'208";a="44509446" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 28 Oct 2019 23:22:38 -0800 IronPort-SDR: KuEAr4QiyfcFRsg+dUfSgvAU0VZ5J4zJpU1ztGfLe7MZQMLpI+YBqSTt3SlSKUV0hj9+GSFwGd ebhtC3tWUrZzN7pdNpkijh+ORnxtmpuT80EfqME/xgtpsE53ck0mM6kFKOpEo2nUY23z6KB1Sh 0yg+rYUJUX2wcbaF6w0YSYov9Ty5ty78uUJaPDJP6wZ7lZs7BMwYxqvgbXEOPQgGnovbLLLFiV vImwsB3vmliTio5gLGL9J/pC2DRaQmFRtfrgJAY7mbC6/zIX1txeiuLvxLYfImrku760zYLuvb /5U= From: Jiada Wang To: , , , CC: , , , , Subject: [PATCH v4 40/48] Input: Atmel: improve error handling in mxt_update_cfg() Date: Tue, 29 Oct 2019 16:20:02 +0900 Message-ID: <20191029072010.8492-41-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191029072010.8492-1-jiada_wang@mentor.com> References: <20191029072010.8492-1-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index a0e5910e6a2a..d05ead2e605b 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2186,7 +2186,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.17.1