From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: linux-input@vger.kernel.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] Input: synaptics-rmi4 - clear IRQ enables for F54
Date: Tue, 12 Nov 2019 16:49:47 -0800 [thread overview]
Message-ID: <20191113004947.GL13374@dtor-ws> (raw)
In-Reply-To: <20191105114402.6009-1-l.stach@pengutronix.de>
On Tue, Nov 05, 2019 at 12:44:02PM +0100, Lucas Stach wrote:
> The driver for F54 just polls the status and doesn't even have a IRQ
> handler registered. Make sure to disable all F54 IRQs, so we don't crash
> the kernel on a nonexistent handler.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_f54.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index 710b02595486..7e6243ecaf32 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -601,7 +601,7 @@ static int rmi_f54_config(struct rmi_function *fn)
> {
> struct rmi_driver *drv = fn->rmi_dev->driver;
>
> - drv->set_irq_bits(fn->rmi_dev, fn->irq_mask);
> + drv->clear_irq_bits(fn->rmi_dev, fn->irq_mask);
>
> return 0;
> }
> --
> 2.20.1
>
--
Dmitry
prev parent reply other threads:[~2019-11-13 0:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 11:44 [PATCH] Input: synaptics-rmi4 - clear IRQ enables for F54 Lucas Stach
2019-11-13 0:49 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113004947.GL13374@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).