* [PATCH] Input: synaptics-rmi4 - clear IRQ enables for F54
@ 2019-11-05 11:44 Lucas Stach
2019-11-13 0:49 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2019-11-05 11:44 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, kernel, patchwork-lst
The driver for F54 just polls the status and doesn't even have a IRQ
handler registered. Make sure to disable all F54 IRQs, so we don't crash
the kernel on a nonexistent handler.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/input/rmi4/rmi_f54.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index 710b02595486..7e6243ecaf32 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -601,7 +601,7 @@ static int rmi_f54_config(struct rmi_function *fn)
{
struct rmi_driver *drv = fn->rmi_dev->driver;
- drv->set_irq_bits(fn->rmi_dev, fn->irq_mask);
+ drv->clear_irq_bits(fn->rmi_dev, fn->irq_mask);
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: synaptics-rmi4 - clear IRQ enables for F54
2019-11-05 11:44 [PATCH] Input: synaptics-rmi4 - clear IRQ enables for F54 Lucas Stach
@ 2019-11-13 0:49 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2019-11-13 0:49 UTC (permalink / raw)
To: Lucas Stach; +Cc: linux-input, kernel, patchwork-lst
On Tue, Nov 05, 2019 at 12:44:02PM +0100, Lucas Stach wrote:
> The driver for F54 just polls the status and doesn't even have a IRQ
> handler registered. Make sure to disable all F54 IRQs, so we don't crash
> the kernel on a nonexistent handler.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_f54.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index 710b02595486..7e6243ecaf32 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -601,7 +601,7 @@ static int rmi_f54_config(struct rmi_function *fn)
> {
> struct rmi_driver *drv = fn->rmi_dev->driver;
>
> - drv->set_irq_bits(fn->rmi_dev, fn->irq_mask);
> + drv->clear_irq_bits(fn->rmi_dev, fn->irq_mask);
>
> return 0;
> }
> --
> 2.20.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-13 0:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 11:44 [PATCH] Input: synaptics-rmi4 - clear IRQ enables for F54 Lucas Stach
2019-11-13 0:49 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).