From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: synaptics-rmi4 - add missed operations in remove
Date: Wed, 13 Nov 2019 11:50:25 -0800 [thread overview]
Message-ID: <20191113195025.GR13374@dtor-ws> (raw)
In-Reply-To: <CANhBUQ3CaRm1SjO4DJOSHpodUpJrHstzD5MYk13vo=EEigDEYA@mail.gmail.com>
On Wed, Nov 13, 2019 at 04:52:59PM +0800, Chuhong Yuan wrote:
> On Wed, Nov 13, 2019 at 4:23 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Wed, Nov 13, 2019 at 02:36:56PM +0800, Chuhong Yuan wrote:
> > > The driver forgets to deal with work and workqueue in remove like what
> > > is done when probe fails.
> > > Add the missed operations to fix it.
> >
> > Is it really possible for the work to still be pending when fully
> > registered device is properly unregistered? I thought we'd wait for
> > successful data acquisition in rmi_f54_buffer_queue() before unregister
> > can complete.
> >
>
> In fact, I am not familiar with the mechanism here...
> I have checked other drivers with video_unregister_device and found none of
> them deals with work in remove.
> Therefore, I think your opinion should be right and we only need to deal with
> the workqueue.
OK, please send the updated patch then.
Thanks!
--
Dmitry
prev parent reply other threads:[~2019-11-13 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 6:36 [PATCH] Input: synaptics-rmi4 - add missed operations in remove Chuhong Yuan
2019-11-13 8:23 ` Dmitry Torokhov
2019-11-13 8:52 ` Chuhong Yuan
2019-11-13 19:50 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113195025.GR13374@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=hslester96@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).