From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F61C432C0 for ; Sun, 1 Dec 2019 03:05:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 010C22082E for ; Sun, 1 Dec 2019 03:05:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A6/PGtZa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbfLADFt (ORCPT ); Sat, 30 Nov 2019 22:05:49 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:46317 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbfLADFt (ORCPT ); Sat, 30 Nov 2019 22:05:49 -0500 Received: by mail-pj1-f65.google.com with SMTP id z21so3590585pjq.13; Sat, 30 Nov 2019 19:05:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rQr7XNF2CkV0Knk0SxxgNZU5CvZQYbz5vW9aYeoWsq4=; b=A6/PGtZag+j6lvjJNB/PcxnJjg1v1PWnsXu6r1NIMIgoRyiH6lxL/uuIGf4Ipvtpjw /BTWeMBYHZ32I94RLV1uEOf59e8V95FS0yUcNYdDsTKakbAZPdIK70zZhds6zhnjCXif Z6MrRdgzsVJNRk3FcaGs/gv0EBS/St3xrkAxMWMyHcNpu7d3hKv8rGutTW59t6kvdNz4 Kes3t/UgWM9QZ49PFMRmqhvHQO3/hdWwynSnk0JMSlHuEnK1o91gUP9pkooTEyt4h6fG phF7mBcBU5fnUNhaC5sGrw2zN7OpOB0SgMtKMtA987KVGtHbi2oOo4IMJtkRhqsvEU3f v7Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rQr7XNF2CkV0Knk0SxxgNZU5CvZQYbz5vW9aYeoWsq4=; b=stnZlLg8ZdIkBqdr6xFs6R9KerI1ohJRzvm3e2UNGhoqMbbENCskHOqACi2kTeqWxh 252NPv4jG0Q6hX5nF5IS0/NDKuNJJjH681qypM7VfoBRjrGnQPqh5Wnjrf4Kx3jYXtdo R2puxbcXvwllmwZJDOILEuMdHgthu2XT1lY4XBL6PruUb0LXedFxXAu3fhja7B1C+x9U hen15ETvzEnv3HoGIa87ASI0j+L2gq3H1MBPhVvnp+8sFx6vFdS5f7rvV2FPRw3wDYMc 8hMoxtu7vBNhJrvJ0tFuvjqbiwGrOugyguBvBmCknuNGUE/AqV4+jHw854vgK4c3bbB0 aXHA== X-Gm-Message-State: APjAAAXjg2fB6+vJj+Ydl46sloQyT5QNmCGegQvuNGTQulM1DgS0H1rp JC4pQgy2Z4vKxLs2l9WuzQw= X-Google-Smtp-Source: APXvYqxkHMMbw3Lgv2DOuluJOoWIpO9xmCGcngM5uTtlOyQj5gKD3ee1fpmnHBQf5ZSGNEZ5y0gQYQ== X-Received: by 2002:a17:90a:de4:: with SMTP id 91mr28019984pjv.113.1575169548180; Sat, 30 Nov 2019 19:05:48 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id e188sm4572713pfe.113.2019.11.30.19.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Nov 2019 19:05:47 -0800 (PST) Date: Sat, 30 Nov 2019 19:05:45 -0800 From: Dmitry Torokhov To: Yannick Fertre Cc: Philippe Cornu , Benjamin Gaignard , Bastien Nocera , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: goodix: request_irq: convert gpio to irq Message-ID: <20191201030545.GL248138@dtor-ws> References: <1574850541-13577-1-git-send-email-yannick.fertre@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1574850541-13577-1-git-send-email-yannick.fertre@st.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Nov 27, 2019 at 11:29:01AM +0100, Yannick Fertre wrote: > From: Yannick Fertré > > Convert gpio to irq if not already done by gpio lib. No, please make sure that dts specifies "interrupts" property. It is marked as "required" in the binding. Thanks. -- Dmitry