From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: uinput - Fix returning EPOLLOUT from uinput_poll
Date: Wed, 4 Dec 2019 17:27:34 -0800 [thread overview]
Message-ID: <20191205012734.GN50317@dtor-ws> (raw)
In-Reply-To: <20191204025014.5189-1-marcel@holtmann.org>
On Wed, Dec 04, 2019 at 03:50:14AM +0100, Marcel Holtmann wrote:
> Always return EPOLLOUT from uinput_poll to allow polling /dev/uinput
> for writable state.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> Cc: stable@vger.kernel.org
Applied, thank you.
> ---
> drivers/input/misc/uinput.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
> index 84051f20b18a..fd253781be71 100644
> --- a/drivers/input/misc/uinput.c
> +++ b/drivers/input/misc/uinput.c
> @@ -695,7 +695,7 @@ static __poll_t uinput_poll(struct file *file, poll_table *wait)
> if (udev->head != udev->tail)
> return EPOLLIN | EPOLLRDNORM;
>
> - return 0;
> + return EPOLLOUT | EPOLLWRNORM;
> }
>
> static int uinput_release(struct inode *inode, struct file *file)
> --
> 2.23.0
>
--
Dmitry
prev parent reply other threads:[~2019-12-05 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 2:50 [PATCH] Input: uinput - Fix returning EPOLLOUT from uinput_poll Marcel Holtmann
2019-12-05 1:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205012734.GN50317@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).