From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43FC2C11D2F for ; Mon, 24 Feb 2020 16:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A90420836 for ; Mon, 24 Feb 2020 16:13:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="SIibQvtY"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="D0LBK/mU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727489AbgBXQNi (ORCPT ); Mon, 24 Feb 2020 11:13:38 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:40799 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727874AbgBXQNi (ORCPT ); Mon, 24 Feb 2020 11:13:38 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 394406D98; Mon, 24 Feb 2020 11:13:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 24 Feb 2020 11:13:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=q96RioY8BsR7brS2orsnP3F5i2+ XuFH0NxA6g4n1MCU=; b=SIibQvtYJJh2Z2bUPQ48iYczwowW5hI6SjxL8fF0bXz F6AAgLsYlkg+gV2inWgm6U4JrwoJneHW5GivyL7tcsyi2+iXFvq0VTTLs5xeoUgh ailh6Dh9OgE3NXpemYsA856ULtNHOBA5acxXqzJfut03zx5YYgJTlFvmqocFSm3S uJTJ6RFp+UzBUlV15JegYoCOiVnU76HPRuXAZBKJXLfT66Gaag2X7UhrutopD+4o J6u8IPjcO2UCX7Ssannt2obo0P/00Y+jZTUfXYh0oh2HFgUL1CZZRXMX8wGeqVBr NFop4LE991CuM0p9dy59PrxKZT318SOVSDUVp9BIV2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=q96Rio Y8BsR7brS2orsnP3F5i2+XuFH0NxA6g4n1MCU=; b=D0LBK/mU6zq4aSxI3aFkS+ cJyPXCWrMTo9T8gFaOcdnYJCNVHBUyfo7V+mcvrGl+6EdlAYCWQy4fCUhjJnhg6I nm3WXkZdFcH0J6juNF5pAr6xqrXJbmulOGhrau7eI8FqLkV4EyI03yIuZ1pKV81H Tc2MvzW+yh6ChrTjwiUyEI3RrnGuM33b3LQQgtgg7EvUz7IHnFl2mXgiHpH5F6C5 kiXIgSUXPLi/e2gq1bCFeC1lBt0VG2ZQHMUCR2yTK0lsv3Zdrx2J+9rVY+aZ9ZvE 1Oa1xwNu5NYgJltfSMKIfVyYl4Mx+5fecqGx20Zqgm145hD5bJqdIS26aicBnN6A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledtgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucffohhmrghinh epmhgvghhouhhsrdgtohhmnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnh hordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id ACEC33060F9B; Mon, 24 Feb 2020 11:13:31 -0500 (EST) Date: Mon, 24 Feb 2020 17:13:30 +0100 From: Maxime Ripard To: linux-sunxi@googlegroups.com, Dmitry Torokhov , Rob Herring , Chen-Yu Tsai , Mark Rutland , Luca Weiss , Tomas Novotny , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/4] ARM: dts: sun8i-a83t-tbs-a711: Add support for the vibrator motor Message-ID: <20200224161330.4att6sleqm3al47f@gilmour.lan> References: <20200222231428.233621-1-megous@megous.com> <20200222231428.233621-4-megous@megous.com> <20200224091059.lljffogofbexhudt@gilmour.lan> <20200224141437.opcsfhozfppulu4g@core.my.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zp4wvrz5w52hdyou" Content-Disposition: inline In-Reply-To: <20200224141437.opcsfhozfppulu4g@core.my.home> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org --zp4wvrz5w52hdyou Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 24, 2020 at 03:14:37PM +0100, Ond=C5=99ej Jirman wrote: > Hello, > > On Mon, Feb 24, 2020 at 10:10:59AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Sun, Feb 23, 2020 at 12:14:27AM +0100, Ondrej Jirman wrote: > > > The board has a vibrator mottor. Hook it to the input subsystem. > > > > > > Signed-off-by: Ondrej Jirman > > > --- > > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boo= t/dts/sun8i-a83t-tbs-a711.dts > > > index 2fd31a0a0b344..a22920275e99b 100644 > > > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > > @@ -99,6 +99,11 @@ panel_input: endpoint { > > > }; > > > }; > > > > > > + vibrator { > > > + compatible =3D "gpio-vibrator"; > > > + vcc-supply =3D <®_ldo_io1>; > > > + }; > > > + > > > > LDO IO1 can also be muxed in as a GPIO iirc, why did you choose the > > regulator instead? > > According to the specification, LDO needs to be enabled (value 0b11) > to achieve the specified max driving current of 150mA: > > https://megous.com/dl/tmp/92b7d9d94820c3ba.png > > Otherwise the chip is probably just using the regular CMOS logic output > (typically limited to around 20-35mA, but not specified in this datasheet= ), > which would be probably overdriven, if we try to drive the motor with it. > > And since we're driving a motor directly, the more the better. Ok, that works for me then. This is typically the kind of things that should be in your commit log though, since it's basically the motivation for doing what you're doing in your patches. Maxime --zp4wvrz5w52hdyou Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXlP2KgAKCRDj7w1vZxhR xcqcAQCXerWJNQWeY178xiMvfPAmMNbC8H5ZByXeaxC/SXh6uwD+IosF9jDvAZpG y+FKGGhJKhcy68xqvVnjrDUxrAJjKg4= =Cv2A -----END PGP SIGNATURE----- --zp4wvrz5w52hdyou--