From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com, lars@metafoo.de
Subject: Re: [PATCH v4 3/4] Input: adp5589: unify ret & error variables
Date: Thu, 5 Mar 2020 16:29:09 +0300 [thread overview]
Message-ID: <20200305132908.GI4118@kadam> (raw)
In-Reply-To: <20200305131405.6598-3-alexandru.ardelean@analog.com>
On Thu, Mar 05, 2020 at 03:14:04PM +0200, Alexandru Ardelean wrote:
> Both variables are used mostly in the same way in the probe function.
> Having both means that we need to copy 'ret' to 'error' before exiting, so
> just use 'ret' everywhere.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2020-03-05 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 13:14 [PATCH v4 1/4] Input: adp5589: Add default platform data Alexandru Ardelean
2020-03-05 13:14 ` [PATCH v4 2/4] Input: adp5589: Add basic devicetree support Alexandru Ardelean
2020-03-05 13:14 ` [PATCH v4 3/4] Input: adp5589: unify ret & error variables Alexandru Ardelean
2020-03-05 13:29 ` Dan Carpenter [this message]
2020-03-05 13:14 ` [PATCH v4 4/4] Input: adp5589: fix possible memleak of 'kpad' Alexandru Ardelean
2020-04-01 14:05 ` [PATCH v4 1/4] Input: adp5589: Add default platform data Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305132908.GI4118@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexandru.ardelean@analog.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).