From: Rob Herring <robh@kernel.org>
To: Ikjoon Jang <ikjn@chromium.org>
Cc: devicetree@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Nicolas Boitchat <drinkcat@chromium.org>,
linux-input@vger.kernel.org, Ikjoon Jang <ikjn@chromium.org>
Subject: Re: [PATCH v6] dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema
Date: Thu, 5 Mar 2020 10:48:50 -0600 [thread overview]
Message-ID: <20200305164850.GA21459@bogus> (raw)
In-Reply-To: <20200305075302.200959-1-ikjn@chromium.org>
On Thu, 5 Mar 2020 15:53:02 +0800, Ikjoon Jang wrote:
> Convert the ChromeOS EC bindings to json-schema.
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> v6: adjust property dependencies, drop duplicated definitions,
> and set additionalProperties
> v5: unset additionalProperties
> v4: text reflows, add type references, and fix examples
> v3: node name changed in rpmsg example
> v2: cleanup description, fix typos, remove LPC, and add RPMSG example
> ---
> .../devicetree/bindings/mfd/cros-ec.txt | 76 -----------
> .../devicetree/bindings/mfd/cros-ec.yaml | 125 ++++++++++++++++++
> 2 files changed, 125 insertions(+), 76 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/cros-ec.example.dt.yaml: cros-ec@0: 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'
See https://patchwork.ozlabs.org/patch/1249450
Please check and re-submit.
prev parent reply other threads:[~2020-03-05 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 7:53 [PATCH v6] dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema Ikjoon Jang
2020-03-05 8:54 ` Enric Balletbo i Serra
2020-03-06 7:24 ` Lee Jones
2020-03-05 16:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305164850.GA21459@bogus \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=ikjn@chromium.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).