From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588DBC3F2D1 for ; Thu, 5 Mar 2020 17:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 262E620848 for ; Thu, 5 Mar 2020 17:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428683; bh=mtnlBCmHerKf8Q879eLnDJEOQK8W1BiYUPGGqs279ZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e61fsNUV63z5bHsMWhuyjGzny3jWc/6teySMLrzF1OijE6ULpBcMtBTuANx/q8SwX jek5zTnnpr6eGoMlJUmJKMHsiZ1w+m4rbe46u48n/iU8LPP195XOK/ZsbyiXlpBi9q RIjnKAOGH4W/6CZt5sC0d8F/2Y3f6ushm7xsTes8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgCERR6 (ORCPT ); Thu, 5 Mar 2020 12:17:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:42538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728212AbgCERPo (ORCPT ); Thu, 5 Mar 2020 12:15:44 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 349802146E; Thu, 5 Mar 2020 17:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428543; bh=mtnlBCmHerKf8Q879eLnDJEOQK8W1BiYUPGGqs279ZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Znflrc9hibjkRvGdutaffncv8JW26YNyCc3YPdqDGP5Krg7sFaFiKPLxkERCAuLJ5 +ylQs4xgPQMc2Qo8qJ3CkXYEsf3A3O5IwiMN2bsSzdu0dA4ScO//vrN8zMg5CcLPsx tIQbcSChqbxN9TGssa3HE5GRq/g0vxwQM3LU84+M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mansour Behabadi , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 02/19] HID: apple: Add support for recent firmware on Magic Keyboards Date: Thu, 5 Mar 2020 12:15:23 -0500 Message-Id: <20200305171540.30250-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305171540.30250-1-sashal@kernel.org> References: <20200305171540.30250-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Mansour Behabadi [ Upstream commit e433be929e63265b7412478eb7ff271467aee2d7 ] Magic Keyboards with more recent firmware (0x0100) report Fn key differently. Without this patch, Fn key may not behave as expected and may not be configurable via hid_apple fnmode module parameter. Signed-off-by: Mansour Behabadi Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-apple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index d0a81a03ddbdd..8ab8f2350bbcd 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -343,7 +343,8 @@ static int apple_input_mapping(struct hid_device *hdev, struct hid_input *hi, unsigned long **bit, int *max) { if (usage->hid == (HID_UP_CUSTOM | 0x0003) || - usage->hid == (HID_UP_MSVENDOR | 0x0003)) { + usage->hid == (HID_UP_MSVENDOR | 0x0003) || + usage->hid == (HID_UP_HPVENDOR2 | 0x0003)) { /* The fn key on Apple USB keyboards */ set_bit(EV_REP, hi->input->evbit); hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_FN); -- 2.20.1