From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Ikjoon Jang <ikjn@chromium.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Gwendal Grignou <gwendal@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Nicolas Boitchat <drinkcat@chromium.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v6] dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema
Date: Fri, 6 Mar 2020 07:24:38 +0000 [thread overview]
Message-ID: <20200306072438.GH3332@dell> (raw)
In-Reply-To: <199d9fc9-5eba-c135-14a5-e78000859f47@collabora.com>
On Thu, 05 Mar 2020, Enric Balletbo i Serra wrote:
> Hi Ikjoon,
>
> On 5/3/20 8:53, Ikjoon Jang wrote:
> > Convert the ChromeOS EC bindings to json-schema.
> >
> > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> > ---
> > v6: adjust property dependencies, drop duplicated definitions,
> > and set additionalProperties
> > v5: unset additionalProperties
> > v4: text reflows, add type references, and fix examples
> > v3: node name changed in rpmsg example
> > v2: cleanup description, fix typos, remove LPC, and add RPMSG example
> > ---
> > .../devicetree/bindings/mfd/cros-ec.txt | 76 -----------
> > .../devicetree/bindings/mfd/cros-ec.yaml | 125 ++++++++++++++++++
>
> According to the feedback I received on other patches from Rob, the name of the
> file should include the vendor, in that case should be google,cros-ec.yaml
>
> I already argued in previous version why I think this should go in
> bindings/chrome instead of mfd, these bindings correspond to the platform/chrome
> device not the mfd cros ec device (cros-ec-dev) in MFD, anyway, I don't want to
> be touchy, but, as is, should go through the Lee Jones tree not our
> chrome-platform tree. So if Lee is fine with it I'm fine too.
Actually these have been reviewed and taken by Rob of late.
> Just another minor change (see below) and looks good to me.
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-03-06 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 7:53 [PATCH v6] dt-bindings: mfd: Convert ChromeOS EC bindings to json-schema Ikjoon Jang
2020-03-05 8:54 ` Enric Balletbo i Serra
2020-03-06 7:24 ` Lee Jones [this message]
2020-03-05 16:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306072438.GH3332@dell \
--to=lee.jones@linaro.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=ikjn@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).