From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D39C10DCE for ; Fri, 6 Mar 2020 19:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E78D320726 for ; Fri, 6 Mar 2020 19:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgCFTEn (ORCPT ); Fri, 6 Mar 2020 14:04:43 -0500 Received: from muru.com ([72.249.23.125]:59234 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgCFTEm (ORCPT ); Fri, 6 Mar 2020 14:04:42 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6DCAF8027; Fri, 6 Mar 2020 19:05:27 +0000 (UTC) Date: Fri, 6 Mar 2020 11:04:38 -0800 From: Tony Lindgren To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Arthur Demchenkov , Merlijn Wajer , Pavel Machek , Sebastian Reichel Subject: Re: [PATCH 1/2] Input: omap4-keypad - Configure interrupt as level Message-ID: <20200306190438.GL37466@atomide.com> References: <20200227020407.17276-1-tony@atomide.com> <20200306185805.GF217608@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200306185805.GF217608@dtor-ws> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org * Dmitry Torokhov [200306 18:58]: > Hi Tony, > > On Wed, Feb 26, 2020 at 06:04:06PM -0800, Tony Lindgren wrote: > > The interrupt should be level high for SoC internal devices. > > Otherwise interrupts may not be seen after a wake-up event. > > > > Cc: Arthur Demchenkov > > Cc: Merlijn Wajer > > Cc: Pavel Machek > > Cc: Sebastian Reichel > > Signed-off-by: Tony Lindgren > > --- > > drivers/input/keyboard/omap4-keypad.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c > > --- a/drivers/input/keyboard/omap4-keypad.c > > +++ b/drivers/input/keyboard/omap4-keypad.c > > @@ -344,7 +344,8 @@ static int omap4_keypad_probe(struct platform_device *pdev) > > } > > > > error = request_threaded_irq(keypad_data->irq, omap4_keypad_irq_handler, > > - omap4_keypad_irq_thread_fn, IRQF_ONESHOT, > > + omap4_keypad_irq_thread_fn, > > + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > > Can't we rely on DT/platform to configure this properly? Oops yeah you're right, and we already have that set with IRQ_TYPE_LEVEL_HIGH in dts. Sorry I was again diffing against the old v3.0.8 vendor kernel trying to figure out what they were doing for the lost keys and spotted this change :) So this patch can be just ignored. Regards, Tony