From: Jonathan Cameron <jic23@kernel.org>
To: Artur Rojek <contact@artur-rojek.eu>
Cc: Rob Herring <robh@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Heiko Stuebner <heiko@sntech.de>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 4/5] dt-bindings: input: Add docs for ADC driven joystick.
Date: Sun, 15 Mar 2020 09:28:52 +0000 [thread overview]
Message-ID: <20200315092852.2d2ecebb@archlinux> (raw)
In-Reply-To: <bb188a58f29dfedcf56bb420f07a6813@artur-rojek.eu>
On Mon, 09 Mar 2020 22:41:00 +0100
Artur Rojek <contact@artur-rojek.eu> wrote:
> Hi Rob,
>
> On 2020-03-09 21:38, Rob Herring wrote:
> > On Sat, 7 Mar 2020 22:14:11 +0100, Artur Rojek wrote:
> >> Add documentation for the adc-joystick driver, used to provide support
> >> for joysticks connected over ADC.
> >>
> >> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> >> Tested-by: Paul Cercueil <paul@crapouillou.net>
> >> ---
> >>
> >> Changes:
> >>
> >> v2: - Add `reg` property to axis subnode in order to enumerate the
> >> axes,
> >> - rename `linux,abs-code` property to `linux,code`,
> >> - drop `linux,` prefix from the remaining properties of axis
> >> subnode
> >>
> >> v3: no change
> >>
> >> v4: - remove "bindings" from the unique identifier string,
> >> - replace `|` with `>` for all description properties,
> >> - specify the number of items for `io-channels`,
> >> - correct the regex pattern of `axis` property,
> >> - specify the value range of `reg` property for each axis,
> >> - put `abs-range` properties under `allOf`
> >>
> >> .../bindings/input/adc-joystick.yaml | 121
> >> ++++++++++++++++++
> >> 1 file changed, 121 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/input/adc-joystick.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> Like with the previous versions of this patch set, the DTS example
> requires that
> patch [2/5] is applied first. When that is done, the DT check does
> succeed here.
Fair enough as far as I am concerned. There were enough comments
from Rob in the previous version though that I'd definitely like
him to take another look before I pick this series up.
Thanks,
Jonathan
>
> Regards,
> Artur
> >
> > Error:
> > Documentation/devicetree/bindings/input/adc-joystick.example.dts:22.31-32
> > syntax error
> > FATAL ERROR: Unable to parse input tree
> > scripts/Makefile.lib:311: recipe for target
> > 'Documentation/devicetree/bindings/input/adc-joystick.example.dt.yaml'
> > failed
> > make[1]: ***
> > [Documentation/devicetree/bindings/input/adc-joystick.example.dt.yaml]
> > Error 1
> > Makefile:1262: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> >
> > See https://patchwork.ozlabs.org/patch/1250951
> > Please check and re-submit.
next prev parent reply other threads:[~2020-03-15 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 21:14 [PATCH v4 1/5] IIO: Ingenic JZ47xx: Add xlate cb to retrieve correct channel idx Artur Rojek
2020-03-07 21:14 ` [PATCH v4 2/5] dt-bindings: iio/adc: Add touchscreen idx for JZ47xx SoC ADC Artur Rojek
2020-03-07 21:14 ` [PATCH v4 3/5] IIO: Ingenic JZ47xx: Add touchscreen mode Artur Rojek
2020-03-07 21:14 ` [PATCH v4 4/5] dt-bindings: input: Add docs for ADC driven joystick Artur Rojek
2020-03-09 20:38 ` Rob Herring
2020-03-09 21:41 ` Artur Rojek
2020-03-15 9:28 ` Jonathan Cameron [this message]
2020-03-20 0:15 ` Rob Herring
2020-03-07 21:14 ` [PATCH v4 5/5] input: joystick: Add ADC attached joystick driver Artur Rojek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315092852.2d2ecebb@archlinux \
--to=jic23@kernel.org \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).