From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0EAFC18E5B for ; Mon, 16 Mar 2020 03:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A949D206E9 for ; Mon, 16 Mar 2020 03:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584328080; bh=Ta/7YQGMbWyIGTwkBfx9j6N2DjoHmcD3pjam5ZHomYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=grop/Dwc8zbgr1BnvZw110FRTzMlop4Ng4Ww/FXnnc/oMw6JSix3CZqSBWIOhagki ha0Vkg2aEO2vFe9yf0STKyW1VXr0gADUmDg9biz+9CZsXF0s0BWwGvoL9cb2sMCb+W Jp68611DQzwvgYDhn5zlhwu4wvIaDISfGD8jGQQ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729441AbgCPDIA (ORCPT ); Sun, 15 Mar 2020 23:08:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:51988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729384AbgCPDIA (ORCPT ); Sun, 15 Mar 2020 23:08:00 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B83B420409; Mon, 16 Mar 2020 03:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584328079; bh=Ta/7YQGMbWyIGTwkBfx9j6N2DjoHmcD3pjam5ZHomYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuPz9BDeEmfsDued5suhi+F0CzjEaeD6rv51BFRYQ1JaiZD34V1qqxHrXeYsPG8zj XJXVKJ1sBrjUt3Ir53ZsoMrcqk/HSbkX4EXZp3wKxeD2iUNhqlSKLac+Dt3aXcpzLA Kjjwq/qCLJvbt4xwZRgKKwRuuvh3evpEwRSh3zWY= Date: Mon, 16 Mar 2020 11:07:45 +0800 From: Shawn Guo To: Peng Fan Cc: Anson Huang , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "dmitry.torokhov@gmail.com" , "a.zummo@towertech.it" , "alexandre.belloni@bootlin.com" , "rui.zhang@intel.com" , "daniel.lezcano@linaro.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , Daniel Baluta , "gregkh@linuxfoundation.org" , "linux@rempel-privat.de" , "tglx@linutronix.de" , "m.felsch@pengutronix.de" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "ronald@innovation.ch" , "krzk@kernel.org" , "robh@kernel.org" , Leonard Crestez , Aisheng Dong , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200316030744.GC17221@dragon> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200316005219.GD17221@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Mar 16, 2020 at 02:51:47AM +0000, Peng Fan wrote: > Hi Shawn, > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > case > > > > On Mon, Mar 09, 2020 at 01:40:18PM +0000, Peng Fan wrote: > > > > Subject: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > > > case > > > > > > I have one patch pending reviewing. > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > > > hwork.kernel.org%2Fpatch%2F11395247%2F&data=02%7C01%7Cpeng.f > > an%40n > > > > > xp.com%7C995815002e2b490791e008d7c9445133%7C686ea1d3bc2b4c6fa9 > > 2cd99c5c > > > > > 301635%7C0%7C0%7C637199167574579419&sdata=RM4Mtwl8LZ3ft9 > > 3uL3FQPcHT > > > 9lPHSqBOgugozkcLvag%3D&reserved=0 > > > > I dropped that patch from my queue and picked patch #2 from this series as > > the favor. > > I think dropping that patch might cause Linux-next build fail as previously showed, > because IMX_SCU_SOC depends on COMPILE_TEST. If you drop that patch, > also need to drop COMPILE_TEST from IMX_SCU_SOC. > > ld: drivers/soc/imx/soc-imx-scu.o: in function `.imx_scu_soc_probe': > soc-imx-scu.c:(.text.imx_scu_soc_probe+0x44): undefined reference to > `.imx_scu_get_handle' > ld: soc-imx-scu.c:(.text.imx_scu_soc_probe+0x134): undefined reference > to `.imx_scu_call_rpc' > ld: soc-imx-scu.c:(.text.imx_scu_soc_probe+0x20c): undefined reference > to `.imx_scu_call_rpc' > > Caused by commit > > 68c189e3a93c ("soc: imx: increase build coverage for imx8m soc > driver") > > What do you prefer? I personally think dummy functions would be good. I would rather drop COMPILE_TEST from IMX_SCU_SOC. Could you send a patch for that shortly? Shawn