From: Marco Felsch <m.felsch@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Oliver Graute <oliver.graute@gmail.com>,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
rydberg@bitmath.org, robh@kernel.org,
mylene.josserand@bootlin.com, p.zabel@pengutronix.de
Subject: Re: RFC: Input: edt-ft5x06 - FT6336G Touch Panel
Date: Mon, 16 Mar 2020 21:01:57 +0100 [thread overview]
Message-ID: <20200316200157.GA17716@pengutronix.de> (raw)
In-Reply-To: <20200316163054.GV1922688@smile.fi.intel.com>
On 20-03-16 18:30, Andy Shevchenko wrote:
> On Mon, Mar 16, 2020 at 03:57:36PM +0100, Oliver Graute wrote:
> > On 02/03/20, Oliver Graute wrote:
> > > Hello,
> > >
> > > I have on of these FT6336G Touch Panels here and I try to get it work
> > > with the ft6236 driver. It comes up with model identification "0x11". So
> > > I added that identification to the switch case in
> > > edt_ft5x06_ts_identify(). But it crashes directly after the probe with a
> > > corrupted stack. No clue why. Some ideas?
> >
> > I still observe sometimes crashes with ft6236G. When it occurs it is
> > always a stack corruption in the probe function on bootup.
> >
> > No clue why stack is corrupted sometimes. Is this related to the buggy
> > revision field?
> >
> > Some further suggestions for debugging this?
>
> Are you sure you have proper I²C bus settings on electrical level
> (pull-up strength, line capacitance, etc.)?
>
> > [ 3.806780] edt_ft5x06 1-0038: Model "EP0110M09", Rev. "�", 0x0 sensors
> > [ 3.808468] at24 2-0050: 2-0050 supply vcc not found, using dummy regulator
> > [ 3.814864] DEBUG: edt_ft5x06_ts_probe 1201
> > [ 3.826215] DEBUG: edt_ft5x06_ts_probe 1211
> > [ 3.830512] DEBUG: edt_ft5x06_ts_probe 1214
> > [ 3.834904] input: EP0110M09 as /devices/platform/bus@5a000000/5a820000.i2c/i2c-1/1-0038/input/input0
> > [ 3.844164] at24 2-0050: 4096 byte 24c32 EEPROM, writable, 1 bytes/write
> > [ 3.844264] DEBUG: edt_ft5x06_ts_probe 1222
> > [ 3.850919] i2c i2c-2: LPI2C adapter registered
> > [ 3.855187] edt_ft5x06 1-0038: EDT FT5x06 initialized: IRQ 55, WAKE pin -1, Reset pin -1.
>
> > [ 3.867878] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: edt_ft5x06_ts_probe+0x5c4/0xb00
>
> Maybe you can look at the assembly to see how compiler puts variables on stack. Also enabling KASAN might help.
This would be the easiest way to debug such failures and since ARMv8
support it you just need to enable it =)
Regards,
Marco
next prev parent reply other threads:[~2020-03-16 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 14:30 RFC: Input: edt-ft5x06 - FT6336G Touch Panel Oliver Graute
2020-03-02 15:00 ` Andy Shevchenko
2020-03-02 17:15 ` Oliver Graute
2020-03-02 18:43 ` Marco Felsch
2020-03-03 19:37 ` Oliver Graute
2020-03-04 7:10 ` Marco Felsch
2020-03-05 16:36 ` Oliver Graute
2020-03-16 14:57 ` Oliver Graute
2020-03-16 16:30 ` Andy Shevchenko
2020-03-16 20:01 ` Marco Felsch [this message]
2020-03-17 16:57 ` Oliver Graute
2020-03-17 17:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316200157.GA17716@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mylene.josserand@bootlin.com \
--cc=oliver.graute@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).