From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: dmitry.torokhov@gmail.com, m.felsch@pengutronix.de,
mylene.josserand@bootlin.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: edt-ft5x06 - add fw_version debugfs file to read
Date: Tue, 17 Mar 2020 12:42:23 +0200 [thread overview]
Message-ID: <20200317104223.GA1922688@smile.fi.intel.com> (raw)
In-Reply-To: <40d823d7-5873-2a3c-9f49-87fdb7428061@puri.sm>
On Tue, Mar 17, 2020 at 11:25:39AM +0100, Martin Kepplinger wrote:
> On 16.03.20 15:40, Andy Shevchenko wrote:
> > On Mon, Mar 16, 2020 at 03:27:56PM +0100, Martin Kepplinger wrote:
> >> Add simple fw_version file in debugfs to read the value from 0xa6
> >> which is the firmware version.
> >
> >
> > If you switch to regmap I²C API you will get this for free for all defined
> > registers.
> >
> > So, I highly recommend to consider above.
> >
>
> I don't know all the devices and modes well enough if the current raw
> read/write buffers always translate to (only) buf[0] being the register
> address.
>
> If you tell me I can assume just that, I'm happy to do a larger change
> that completely does aways with the current raw buffers.
I have only one device at hand, so, I can't tell for all neither.
Maybe Dmitry has an opinion on this?
> Otherwise:
>
> Does is make sense to *add* just a few regmap calls but keep the current
> i2c_transfer in place for the calls I'm not sure about? I could do that
> in any case.
I think it's way to the opposite direction, i.e. increasing burden
(for maintainability) and technical debt.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-03-17 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 14:27 [PATCH] Input: edt-ft5x06 - add fw_version debugfs file to read Martin Kepplinger
2020-03-16 14:40 ` Andy Shevchenko
2020-03-17 10:25 ` Martin Kepplinger
2020-03-17 10:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317104223.GA1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=martin.kepplinger@puri.sm \
--cc=mylene.josserand@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).