From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1769CC2BB1D for ; Tue, 17 Mar 2020 17:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F018F20738 for ; Tue, 17 Mar 2020 17:40:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbgCQRkz (ORCPT ); Tue, 17 Mar 2020 13:40:55 -0400 Received: from mga18.intel.com ([134.134.136.126]:23277 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbgCQRkz (ORCPT ); Tue, 17 Mar 2020 13:40:55 -0400 IronPort-SDR: cJlGU+DR3NCx2Xm0ey7BcSw8XTXYw8HsmH+YqGs7e0HmqFklq0tLmki/R1IywmwfOmo/IvvSvs 7cSyw8ilAEqA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 10:40:54 -0700 IronPort-SDR: LN3pdQDzHHK3p8yjNvcd/u676i+DEI4ndHE7gV4yNOz2Oy2FgzUN7up2zJrYTc/lZposNb9UJ2 Zt5SjHomKwHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,565,1574150400"; d="scan'208";a="263104698" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 17 Mar 2020 10:40:52 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jEGD0-00AWCD-Js; Tue, 17 Mar 2020 19:40:54 +0200 Date: Tue, 17 Mar 2020 19:40:54 +0200 From: Andy Shevchenko To: Oliver Graute Cc: Marco Felsch , linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, rydberg@bitmath.org, robh@kernel.org, mylene.josserand@bootlin.com, p.zabel@pengutronix.de Subject: Re: RFC: Input: edt-ft5x06 - FT6336G Touch Panel Message-ID: <20200317174054.GE1922688@smile.fi.intel.com> References: <20200305163649.GC10366@ripley> <20200316145736.GG16310@optiplex> <20200316163054.GV1922688@smile.fi.intel.com> <20200316200157.GA17716@pengutronix.de> <20200317165705.GA16514@ripley> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200317165705.GA16514@ripley> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, Mar 17, 2020 at 05:57:05PM +0100, Oliver Graute wrote: > On 16/03/20, Marco Felsch wrote: > > On 20-03-16 18:30, Andy Shevchenko wrote: > > > On Mon, Mar 16, 2020 at 03:57:36PM +0100, Oliver Graute wrote: > > > > On 02/03/20, Oliver Graute wrote: > > > > > Hello, > > > > > > > > > > I have on of these FT6336G Touch Panels here and I try to get it work > > > > > with the ft6236 driver. It comes up with model identification "0x11". So > > > > > I added that identification to the switch case in > > > > > edt_ft5x06_ts_identify(). But it crashes directly after the probe with a > > > > > corrupted stack. No clue why. Some ideas? > > > > > > > > I still observe sometimes crashes with ft6236G. When it occurs it is > > > > always a stack corruption in the probe function on bootup. > > > > > > > > No clue why stack is corrupted sometimes. Is this related to the buggy > > > > revision field? > > > > > > > > Some further suggestions for debugging this? > > > > > > Are you sure you have proper I²C bus settings on electrical level > > > (pull-up strength, line capacitance, etc.)? > > > > > > > [ 3.806780] edt_ft5x06 1-0038: Model "EP0110M09", Rev. "�", 0x0 sensors > > > > [ 3.808468] at24 2-0050: 2-0050 supply vcc not found, using dummy regulator > > > > [ 3.814864] DEBUG: edt_ft5x06_ts_probe 1201 > > > > [ 3.826215] DEBUG: edt_ft5x06_ts_probe 1211 > > > > [ 3.830512] DEBUG: edt_ft5x06_ts_probe 1214 > > > > [ 3.834904] input: EP0110M09 as /devices/platform/bus@5a000000/5a820000.i2c/i2c-1/1-0038/input/input0 > > > > [ 3.844164] at24 2-0050: 4096 byte 24c32 EEPROM, writable, 1 bytes/write > > > > [ 3.844264] DEBUG: edt_ft5x06_ts_probe 1222 > > > > [ 3.850919] i2c i2c-2: LPI2C adapter registered > > > > [ 3.855187] edt_ft5x06 1-0038: EDT FT5x06 initialized: IRQ 55, WAKE pin -1, Reset pin -1. > > > > > > > [ 3.867878] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: edt_ft5x06_ts_probe+0x5c4/0xb00 > > > > > > Maybe you can look at the assembly to see how compiler puts variables on stack. Also enabling KASAN might help. > > > > This would be the easiest way to debug such failures and since ARMv8 > > support it you just need to enable it =) > > ok, I enabled KASAN and I got the following trace: Nice. I think it has nothing to do with touch screen. By the way... > [ 0.000000] Linux version 5.6.0-rc1-next-20200214-00057-g9e78f1560095-dirty (alarm@imx8qm) (gcc version 9.2.0 (GCC)) #100 SMP PREEMPT Tue Mar 17 15:54:17 UTC 2020 May you try the latest and greatest release candidate, i.e. v5.6-rc6 w/o any patches applied? Then, enable only touchscreen and try again. Otherwise it's probably good to inform ARM + kasan maintainers about the issue. -- With Best Regards, Andy Shevchenko