From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Hollinsky <phollinsky@holtechnik.com>,
Christopher Heiny <Cheiny@synaptics.com>,
Lucas Stach <l.stach@pengutronix.de>,
kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: Re: [PATCH] Input: synaptics-rmi4 - Do not set reduced reporting mode thresholds are not set by the driver
Date: Tue, 24 Mar 2020 15:45:33 -0700 [thread overview]
Message-ID: <20200324224533.GF75430@dtor-ws> (raw)
In-Reply-To: <20200312005549.29922-1-aduggan@synaptics.com>
On Wed, Mar 11, 2020 at 05:55:49PM -0700, Andrew Duggan wrote:
> The previous patch "c5ccf2ad3d33 (Input: synaptics-rmi4 - switch to
> reduced reporting mode)" enabled reduced reporting mode unintentionally
> on some devices, if the firmware was configured with default Delta X/Y
> threshold values. The result unintentionally degrade the performance of
> some touchpads.
>
> This patch checks to see that the driver is modifying the delta X/Y
> thresholds before modifying the reporting mode.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_f11.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index 6adea8a3e8fb..ffa39ab153f2 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -1203,8 +1203,8 @@ static int rmi_f11_initialize(struct rmi_function *fn)
> * If distance threshold values are set, switch to reduced reporting
> * mode so they actually get used by the controller.
> */
> - if (ctrl->ctrl0_11[RMI_F11_DELTA_X_THRESHOLD] ||
> - ctrl->ctrl0_11[RMI_F11_DELTA_Y_THRESHOLD]) {
> + if (sensor->axis_align.delta_x_threshold ||
> + sensor->axis_align.delta_y_threshold) {
> ctrl->ctrl0_11[0] &= ~RMI_F11_REPORT_MODE_MASK;
> ctrl->ctrl0_11[0] |= RMI_F11_REPORT_MODE_REDUCED;
> }
> --
> 2.20.1
>
--
Dmitry
prev parent reply other threads:[~2020-03-24 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 0:55 [PATCH] Input: synaptics-rmi4 - Do not set reduced reporting mode thresholds are not set by the driver Andrew Duggan
2020-03-12 3:14 ` Peter Hutterer
2020-03-12 10:11 ` Lucas Stach
2020-03-24 22:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324224533.GF75430@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Cheiny@synaptics.com \
--cc=aduggan@synaptics.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=phollinsky@holtechnik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).