linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Rajat Jain <rajatja@google.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	dtor@google.com, Mark Rutland <mark.rutland@arm.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Enrico Weigelt <info@metux.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Stephen Boyd <swboyd@chromium.org>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, furquan@google.com,
	dlaurie@google.com, bleung@google.com, zentaro@google.com,
	dbehr@google.com, rajatxjain@gmail.com
Subject: Re: [PATCH v4 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap"
Date: Fri, 10 Apr 2020 11:41:40 -0500	[thread overview]
Message-ID: <20200410164140.GA25924@bogus> (raw)
In-Reply-To: <20200328185916.98423-3-rajatja@google.com>

On Sat, Mar 28, 2020 at 11:59:14AM -0700, Rajat Jain wrote:
> Create the documentation for the new introduced property, that
> describes the function-row keys physical positions.
> 
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> v4: Same as v3
> v3: same as v2
> v2: Remove the Change-Id from the commit log
> 
>  .../devicetree/bindings/input/atkbd.txt       | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/atkbd.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt
> new file mode 100644
> index 0000000000000..816653eb8e98d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atkbd.txt
> @@ -0,0 +1,34 @@
> +Device tree bindings for AT / PS2 keyboard device
> +
> +Optional properties:
> +
> +	function-row-physmap:
> +			An ordered array of the physical codes for the function
> +			row keys. Arranged in order from left to right.

A single optional property doesn't constitute a DT binding.

> +
> +Example:
> +
> +	This is a sample ACPI _DSD node describing the property:

Neither does this ACPI stuff.

Rob

  reply	other threads:[~2020-04-10 17:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-28 18:59 [PATCH v4 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device Rajat Jain
2020-03-28 18:59 ` [PATCH v4 2/5] Input: atkbd: Expose function row physical map to userspace Rajat Jain
2020-04-24 21:03   ` Dmitry Torokhov
2020-04-27 21:04     ` Rajat Jain
2020-03-28 18:59 ` [PATCH v4 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap" Rajat Jain
2020-04-10 16:41   ` Rob Herring [this message]
2020-04-24 19:41     ` Rajat Jain
2020-03-28 18:59 ` [PATCH v4 4/5] Input: atkbd: Receive and use physcode->keycode mapping from FW Rajat Jain
2020-03-28 18:59 ` [PATCH v4 5/5] dt-bindings: input/atkbd.txt: Add binding info for "keymap" property Rajat Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410164140.GA25924@bogus \
    --to=robh@kernel.org \
    --cc=allison@lohutok.net \
    --cc=bleung@google.com \
    --cc=dbehr@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlaurie@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@google.com \
    --cc=furquan@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=info@metux.net \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rajatja@google.com \
    --cc=rajatxjain@gmail.com \
    --cc=swboyd@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=zentaro@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).