From: Kamel Bouhara <kamel.bouhara@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ARM: at91: add atmel tcb capabilities
Date: Tue, 14 Apr 2020 10:51:53 +0200 [thread overview]
Message-ID: <20200414085153.GC161090@kb-xps> (raw)
In-Reply-To: <20200412113137.1763f084@archlinux>
On Sun, Apr 12, 2020 at 11:31:37AM +0100, Jonathan Cameron wrote:
> On Thu, 9 Apr 2020 16:13:59 +0200
> Kamel Bouhara <kamel.bouhara@bootlin.com> wrote:
>
> > Some atmel socs have extra tcb capabilities that allow using a generic
> > clock source or enabling a quadrature decoder.
> >
> > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> > ---
> > Changes from v2:
> > - Fixed first patch not applying on mainline
> >
> > include/soc/at91/atmel_tcb.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/soc/at91/atmel_tcb.h b/include/soc/at91/atmel_tcb.h
> > index c3c7200ce151..7e47ace9255c 100644
> > --- a/include/soc/at91/atmel_tcb.h
> > +++ b/include/soc/at91/atmel_tcb.h
> > @@ -39,6 +39,8 @@ struct clk;
> > */
> > struct atmel_tcb_config {
> > size_t counter_width;
>
Hi,
> This structure has existing kernel doc. Please add these new
> elements and run ./scripts/kernel-doc over it check for any issues.
>
Its fixed, thanks.
Kamel
> > + bool has_gclk;
> > + bool has_qdec;
> > };
> >
> > /**
> > --
> > 2.25.0
> >
>
> Thanks,
>
> Jonathan
--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-14 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 14:13 [PATCH v2 0/3] Atmel TCB capture driver Kamel Bouhara
2020-04-09 14:13 ` [PATCH v2 1/3] ARM: at91: add atmel tcb capabilities Kamel Bouhara
2020-04-12 10:31 ` Jonathan Cameron
2020-04-14 8:51 ` Kamel Bouhara [this message]
2020-04-09 14:14 ` [PATCH v2 2/3] dt-bindings: counter: atmel-tcb-capture counter Kamel Bouhara
2020-04-09 23:11 ` Rob Herring
2020-04-09 14:14 ` [PATCH v2 3/3] counter: Add atmel TCB capture counter Kamel Bouhara
2020-04-12 10:44 ` Jonathan Cameron
2020-04-15 8:40 ` Kamel Bouhara
2020-04-11 16:01 ` [PATCH v2 0/3] Atmel TCB capture driver William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414085153.GC161090@kb-xps \
--to=kamel.bouhara@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).