From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kenny Levinsen <kl@kl.wtf>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input/evdev: make evdev use keyed wakeups
Date: Sat, 18 Apr 2020 21:27:15 -0700 [thread overview]
Message-ID: <20200419042715.GH166864@dtor-ws> (raw)
In-Reply-To: <20200410233557.3892-1-kl@kl.wtf>
On Sat, Apr 11, 2020 at 01:35:57AM +0200, Kenny Levinsen wrote:
> Some processes, such as systemd, are only polling for EPOLLERR|EPOLLHUP.
> As evdev uses unkeyed wakeups, such a poll receives many spurious
> wakeups from uninteresting events.
>
> Use keyed wakeups to allow the wakeup target to more efficiently discard
> these uninteresting events.
>
> Signed-off-by: Kenny Levinsen <kl@kl.wtf>
Applied, thank you.
> ---
> drivers/input/evdev.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index d7dd6fcf2db0..f54d3d31f61d 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -282,7 +282,8 @@ static void evdev_pass_values(struct evdev_client *client,
> spin_unlock(&client->buffer_lock);
>
> if (wakeup)
> - wake_up_interruptible(&evdev->wait);
> + wake_up_interruptible_poll(&evdev->wait,
> + EPOLLIN | EPOLLOUT | EPOLLRDNORM | EPOLLWRNORM);
> }
>
> /*
> @@ -443,7 +444,7 @@ static void evdev_hangup(struct evdev *evdev)
> kill_fasync(&client->fasync, SIGIO, POLL_HUP);
> spin_unlock(&evdev->client_lock);
>
> - wake_up_interruptible(&evdev->wait);
> + wake_up_interruptible_poll(&evdev->wait, EPOLLHUP | EPOLLERR);
> }
>
> static int evdev_release(struct inode *inode, struct file *file)
> @@ -958,7 +959,7 @@ static int evdev_revoke(struct evdev *evdev, struct evdev_client *client,
> client->revoked = true;
> evdev_ungrab(evdev, client);
> input_flush_device(&evdev->handle, file);
> - wake_up_interruptible(&evdev->wait);
> + wake_up_interruptible_poll(&evdev->wait, EPOLLHUP | EPOLLERR);
>
> return 0;
> }
> --
> 2.26.0
>
--
Dmitry
prev parent reply other threads:[~2020-04-19 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 23:35 [PATCH] input/evdev: make evdev use keyed wakeups Kenny Levinsen
2020-04-19 4:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419042715.GH166864@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kl@kl.wtf \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).