From: Kevin Locke <kevin@kevinlocke.name>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: i8042 - add ThinkPad S230u to i8042 nomux list
Date: Thu, 23 Apr 2020 22:25:00 -0600 [thread overview]
Message-ID: <20200424042500.GA107217@kevinolos.locke.internal> (raw)
In-Reply-To: <20200420170234.GN166864@dtor-ws>
On Mon, 2020-04-20 at 10:02 -0700, Dmitry Torokhov wrote:
> Applied, thank you.
I believe I was in error and nomux only appeared to fix the issue
because the controller continued working after warm reboots. After
more thorough testing from both warm and cold start, I now believe the
entry should be added to i8042_dmi_reset_table rather than
i8042_dmi_nomux_table as i8042.reset=1 alone is sufficient to avoid
the issue from both states while i8042.nomux is not.
Please drop or revert the previous patch, if possible.
I will send a corrected and better-tested patch momentarily.
My apologies for the confusion,
Kevin
next prev parent reply other threads:[~2020-04-24 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 16:37 [PATCH] Input: i8042 - add ThinkPad S230u to i8042 nomux list Kevin Locke
2020-04-20 17:02 ` Dmitry Torokhov
2020-04-24 4:25 ` Kevin Locke [this message]
2020-04-24 4:30 ` [PATCH] Input: i8042 - add ThinkPad S230u to i8042 reset list Kevin Locke
2020-04-28 1:08 ` Dmitry Torokhov
2020-04-28 1:08 ` [PATCH] Input: i8042 - add ThinkPad S230u to i8042 nomux list Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424042500.GA107217@kevinolos.locke.internal \
--to=kevin@kevinlocke.name \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).