Re: [PATCH] Input: i8042 - add ThinkPad S230u to i8042 reset list

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Apr 23, 2020 at 10:30:36PM -0600, Kevin Locke wrote:
> On the Lenovo ThinkPad Twist S230u (3347-4HU) with BIOS version
> "GDETC1WW (1.81 ) 06/27/2019", the keyboard, Synaptics TouchPad, and
> TrackPoint either do not function or stop functioning a few minutes
> after boot.  This problem has been noted before, perhaps only occurring
> with BIOS 1.57 and later.[1][2][3][4][5]
> 
> Odds of a BIOS fix appear to be low: 1.57 was released over 6 years ago
> and although the [BIOS changelog] notes "Fixed an issue of UEFI
> touchpad/trackpoint/keyboard/touchscreen" in 1.58, it appears to be
> insufficient.
> 
> Setting i8042.reset=1 or adding 33474HU to the reset list avoids the
> issue on my system from either warm or cold boot.
> 
> [1]: https://bugs.launchpad.net/bugs/1210748
> [2]: https://bbs.archlinux.org/viewtopic.php?pid=1360425
> [3]: https://forums.linuxmint.com/viewtopic.php?f=46&t=41200
> [4]: https://forums.linuxmint.com/viewtopic.php?f=49&t=157115
> [5]: https://forums.lenovo.com/topic/findpost/27/1337119
> [BIOS changelog]: https://download.lenovo.com/pccbbs/mobiles/gduj33uc.txt
> 
> Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
> Cc: stable@vger.kernel.org

Applied, thank you.

> ---
>  drivers/input/serio/i8042-x86ia64io.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 08e919dbeb5d..7e048b557462 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -662,6 +662,13 @@ static const struct dmi_system_id __initconst i8042_dmi_reset_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "P65xRP"),
>  		},
>  	},
> +	{
> +		/* Lenovo ThinkPad Twist S230u */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "33474HU"),
> +		},
> +	},
>  	{ }
>  };
>  
> -- 
> 2.26.2
> 

-- 
Dmitry