* [PATCH] Input: stmpe-ts - add missed input_unregister_device
@ 2020-05-07 15:12 Chuhong Yuan
2020-05-07 16:01 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2020-05-07 15:12 UTC (permalink / raw)
Cc: Dmitry Torokhov, Maxime Coquelin, Alexandre Torgue, linux-input,
linux-stm32, linux-arm-kernel, linux-kernel, Chuhong Yuan
This driver calls input_register_device() in probe, but misses
input_unregister_device() in remove.
Add the missed function call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/input/touchscreen/stmpe-ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 7e16fcfe3b95..5e62b466629b 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -350,6 +350,7 @@ static int stmpe_ts_remove(struct platform_device *pdev)
{
struct stmpe_touch *ts = platform_get_drvdata(pdev);
+ input_unregister_device(ts->idev);
stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN);
return 0;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: stmpe-ts - add missed input_unregister_device
2020-05-07 15:12 [PATCH] Input: stmpe-ts - add missed input_unregister_device Chuhong Yuan
@ 2020-05-07 16:01 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2020-05-07 16:01 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Maxime Coquelin, Alexandre Torgue, linux-input, linux-stm32,
linux-arm-kernel, linux-kernel
On Thu, May 07, 2020 at 11:12:13PM +0800, Chuhong Yuan wrote:
> This driver calls input_register_device() in probe, but misses
> input_unregister_device() in remove.
> Add the missed function call to fix it.
The input device in question is devm-managed and therefore does not need
explicit unregistering.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-07 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 15:12 [PATCH] Input: stmpe-ts - add missed input_unregister_device Chuhong Yuan
2020-05-07 16:01 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).