* [PATCH] Input: wm831x-ts - add missed input_unregister_device
@ 2020-05-07 15:12 Chuhong Yuan
2020-05-07 15:57 ` Charles Keepax
2020-05-07 16:01 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2020-05-07 15:12 UTC (permalink / raw)
Cc: Dmitry Torokhov, patches, linux-input, linux-kernel, Chuhong Yuan
This driver calls input_register_device() in probe, but misses
input_unregister_device() in remove.
Add the missed function call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/input/touchscreen/wm831x-ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/wm831x-ts.c b/drivers/input/touchscreen/wm831x-ts.c
index 607d1aeb595d..db09dd473ada 100644
--- a/drivers/input/touchscreen/wm831x-ts.c
+++ b/drivers/input/touchscreen/wm831x-ts.c
@@ -379,6 +379,7 @@ static int wm831x_ts_remove(struct platform_device *pdev)
{
struct wm831x_ts *wm831x_ts = platform_get_drvdata(pdev);
+ input_unregister_device(wm831x_ts->input_dev);
free_irq(wm831x_ts->pd_irq, wm831x_ts);
free_irq(wm831x_ts->data_irq, wm831x_ts);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: wm831x-ts - add missed input_unregister_device
2020-05-07 15:12 [PATCH] Input: wm831x-ts - add missed input_unregister_device Chuhong Yuan
@ 2020-05-07 15:57 ` Charles Keepax
2020-05-07 16:01 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2020-05-07 15:57 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Dmitry Torokhov, patches, linux-input, linux-kernel
On Thu, May 07, 2020 at 11:12:59PM +0800, Chuhong Yuan wrote:
> This driver calls input_register_device() in probe, but misses
> input_unregister_device() in remove.
> Add the missed function call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/input/touchscreen/wm831x-ts.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/wm831x-ts.c b/drivers/input/touchscreen/wm831x-ts.c
> index 607d1aeb595d..db09dd473ada 100644
> --- a/drivers/input/touchscreen/wm831x-ts.c
> +++ b/drivers/input/touchscreen/wm831x-ts.c
> @@ -379,6 +379,7 @@ static int wm831x_ts_remove(struct platform_device *pdev)
> {
> struct wm831x_ts *wm831x_ts = platform_get_drvdata(pdev);
>
> + input_unregister_device(wm831x_ts->input_dev);
Are you seeing specific issues caused by this being missing, if
so it would be good if you could elaborate on them? My understanding
is that since this driver uses devm_input_allocate_device
input_unregister_device will be handled automatically, see the
comments on input_register_device/devm_input_allocate_device.
Thanks,
Charles
> free_irq(wm831x_ts->pd_irq, wm831x_ts);
> free_irq(wm831x_ts->data_irq, wm831x_ts);
>
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: wm831x-ts - add missed input_unregister_device
2020-05-07 15:12 [PATCH] Input: wm831x-ts - add missed input_unregister_device Chuhong Yuan
2020-05-07 15:57 ` Charles Keepax
@ 2020-05-07 16:01 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2020-05-07 16:01 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: patches, linux-input, linux-kernel
On Thu, May 07, 2020 at 11:12:59PM +0800, Chuhong Yuan wrote:
> This driver calls input_register_device() in probe, but misses
> input_unregister_device() in remove.
> Add the missed function call to fix it.
The input device in question is devm-managed and therefore does not need
explicit unregistering.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 15:12 [PATCH] Input: wm831x-ts - add missed input_unregister_device Chuhong Yuan
2020-05-07 15:57 ` Charles Keepax
2020-05-07 16:01 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).