linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hutterer <peter.hutterer@who-t.net>
To: Siarhei Vishniakou <svv@google.com>
Cc: Garfield Tan <xutan@google.com>,
	linux-input <linux-input@vger.kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type"
Date: Tue, 12 May 2020 15:22:36 +1000	[thread overview]
Message-ID: <20200512052236.GB48688@koala> (raw)
In-Reply-To: <CAKF84v2gWnokoyhRe_feiWJcYOAPUcWwjaX93GkqmXqm8OzmYg@mail.gmail.com>

Hi Siarhei,

On Wed, Apr 01, 2020 at 01:02:03PM -0700, Siarhei Vishniakou wrote:
> Hello linux-input,
> 
> We have noticed a recent behavior change introduced by the commit:
> https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1
> HID: generic: create one input report per application type.
> 
> We have been looking into the behaviour of the Microsoft Designer
> keyboard. Prior to these patches, the keyboard would report as a
> single input_device to the user space. After these patches, the
> keyboard is now split into 2 input devices: “Designer Keyboard
> Consumer Control” and “"Designer Keyboard Keyboard". We noticed that
> this behavior also applies to the keyboard Dell KB216. In the Dell
> case, it is split into 3 devices, which include “Consumer Control”
> (for some of the media keys) and “System Control” (for the sleep
> button).
> 
> In both Microsoft and Dell cases, these are pretty standard keyboards,
> although they do contain media keys and power/sleep keys.
> 
> Could you please confirm that this new behaviour is indeed
> intentional, and that you wanted keyboards to be split in this
> fashion?

Is there an actual issue with the split though or just a cosmetic one? This
is pretty standard for many keyboards (and other devices) but it shouldn't
have any negative effect on functionality.

Cheers,
   Peter

  parent reply	other threads:[~2020-05-12  5:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 20:02 behaviour change for keyboards introduced by "HID: generic: create one input report per application type" Siarhei Vishniakou
2020-04-08 16:45 ` Siarhei Vishniakou
2020-04-21 21:37   ` Siarhei Vishniakou
2020-05-11 18:09     ` Siarhei Vishniakou
2020-05-12  5:22 ` Peter Hutterer [this message]
2020-05-12 14:34   ` Siarhei Vishniakou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512052236.GB48688@koala \
    --to=peter.hutterer@who-t.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=svv@google.com \
    --cc=xutan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).