From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3068BC54E4B for ; Tue, 12 May 2020 05:22:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0413E20733 for ; Tue, 12 May 2020 05:22:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=who-t.net header.i=@who-t.net header.b="LEj+hBst"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="evXoLdp4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728115AbgELFWp (ORCPT ); Tue, 12 May 2020 01:22:45 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:32873 "EHLO wout5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgELFWp (ORCPT ); Tue, 12 May 2020 01:22:45 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3286F6D7; Tue, 12 May 2020 01:22:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 12 May 2020 01:22:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=who-t.net; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=I 5QiT8/SptEqrGzlHkpUfaVlmT8dyNlUizt2eGrMIeM=; b=LEj+hBsttBeV1apMI RL7Cju0r3ywTOA5npzviQrOPe0leGhtUocWxjh0dmYLWqfu6aizYYVf7WlwDk041 0BQ7T0QifUF0L2urRfm0yFdDZGVMy7FobFQaVQEyLlXoBHgyYk08go91jFAdsR1d /U5iTunygokJYNYEb833qgW9nZpWGQaf1btURQxCWdMpt199lr1+KGBsILw7ayIV y9rONphXubpZkwhmI+hl4GSIuoEbp++zj9fxUpyCL8/d4PyC1hOi+T++QBAi9JLD /O8IurzKfgdpNjzrQUB3ILWdE3zu1TamGOqGfZdRGQnrthhis+zWjw5qREK2u0Or 5cR/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=I5QiT8/SptEqrGzlHkpUfaVlmT8dyNlUizt2eGrMI eM=; b=evXoLdp487BTlDKcZKJ3kEyPM3rD78WA33jtuel0A4NjQYCJZS70aIhBl xgSLCUl3MCH1kvnelpOMry37SPDv2D07QQZ33rfI2ry50PuarE51eVkJTqVidzm0 dHTZOC2RRwyZb53oYmCTwKZW3BkGZ0N3YkZIlsOcMlNhwzBRj4iK6EbEiELS/qHW ixHW75M3ws0POIjY+anwN//sGvjtnmBPGIRM2DwCn46E+SCUX8CPhLHGtBrfJb2x 4Vdy5YbDN/Oz07SZGMcfTzGe9oe9MoqoPX1TkQooF4PXDbmXHmJEw/kRE5Be9N9q E3vbljrkZBX15RG7Z3Nva8YuHiw6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledugdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefrvghtvghr ucfjuhhtthgvrhgvrhcuoehpvghtvghrrdhhuhhtthgvrhgvrhesfihhohdqthdrnhgvth eqnecuggftrfgrthhtvghrnhepkeevledtjeehleekleevtdfggfffudfgfedvtdetuddt ueehkeeluedugeejgfegnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepud dujedrvddtrdejuddruddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehpvghtvghrrdhhuhhtthgvrhgvrhesfihhohdqthdrnhgvth X-ME-Proxy: Received: from koala (117-20-71-109.751447.bne.nbn.aussiebb.net [117.20.71.109]) by mail.messagingengine.com (Postfix) with ESMTPA id 9305E30662BD; Tue, 12 May 2020 01:22:41 -0400 (EDT) Date: Tue, 12 May 2020 15:22:36 +1000 From: Peter Hutterer To: Siarhei Vishniakou Cc: Garfield Tan , linux-input , Benjamin Tissoires , Jiri Kosina Subject: Re: behaviour change for keyboards introduced by "HID: generic: create one input report per application type" Message-ID: <20200512052236.GB48688@koala> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Siarhei, On Wed, Apr 01, 2020 at 01:02:03PM -0700, Siarhei Vishniakou wrote: > Hello linux-input, > > We have noticed a recent behavior change introduced by the commit: > https://github.com/torvalds/linux/commit/f07b3c1da92db108662f99417a212fc1eddc44d1 > HID: generic: create one input report per application type. > > We have been looking into the behaviour of the Microsoft Designer > keyboard. Prior to these patches, the keyboard would report as a > single input_device to the user space. After these patches, the > keyboard is now split into 2 input devices: “Designer Keyboard > Consumer Control” and “"Designer Keyboard Keyboard". We noticed that > this behavior also applies to the keyboard Dell KB216. In the Dell > case, it is split into 3 devices, which include “Consumer Control” > (for some of the media keys) and “System Control” (for the sleep > button). > > In both Microsoft and Dell cases, these are pretty standard keyboards, > although they do contain media keys and power/sleep keys. > > Could you please confirm that this new behaviour is indeed > intentional, and that you wanted keyboards to be split in this > fashion? Is there an actual issue with the split though or just a cosmetic one? This is pretty standard for many keyboards (and other devices) but it shouldn't have any negative effect on functionality. Cheers, Peter