From: "François-Xavier Carton" <fx.carton91@gmail.com>
To: linux-input@vger.kernel.org
Cc: Ethan Lee <flibitijibibo@gmail.com>,
Bastien Nocera <hadess@hadess.net>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH v2 3/4] HID: gamecube-adapter: add auto calibration
Date: Tue, 12 May 2020 10:46:15 +0200 [thread overview]
Message-ID: <20200512084616.32158-3-fx.carton91@gmail.com> (raw)
In-Reply-To: <20200512084616.32158-1-fx.carton91@gmail.com>
The axes do not cover the full 0-255 range, with different limit values
for each axis. The minimal and maximal values are recorded for each axis
and the values are remapped from that range to 0-255.
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
---
drivers/hid/hid-gamecube-adapter.c | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-gamecube-adapter.c b/drivers/hid/hid-gamecube-adapter.c
index 028ce005c9e3..efcbd8f27b67 100644
--- a/drivers/hid/hid-gamecube-adapter.c
+++ b/drivers/hid/hid-gamecube-adapter.c
@@ -55,6 +55,8 @@ enum gamecube_btn {
struct gamecube_ctrl {
struct input_dev __rcu *input;
enum gamecube_ctrl_flags flags;
+ u8 axis_min[6];
+ u8 axis_max[6];
u8 rumble;
struct gamecube_adapter *adpt;
struct work_struct work_connect;
@@ -258,6 +260,7 @@ static void gamecube_ctrl_handle_report(struct gamecube_ctrl *ctrl, u8 *data)
u16 btns = data[1] << 8 | data[2];
u8 old_flags, new_flags = data[0];
unsigned long irq_flags;
+ unsigned int i;
spin_lock_irqsave(&ctrl->flags_lock, irq_flags);
old_flags = ctrl->flags;
@@ -265,6 +268,11 @@ static void gamecube_ctrl_handle_report(struct gamecube_ctrl *ctrl, u8 *data)
spin_unlock_irqrestore(&ctrl->flags_lock, irq_flags);
if ((new_flags & GC_TYPES) != (old_flags & GC_TYPES)) {
+ // Reset min/max values. The default values were obtained empirically
+ for (i = 0; i < 6; i++) {
+ ctrl->axis_min[i] = 45; // max across all axes of min values
+ ctrl->axis_max[i] = 215; // min across all axes of max values
+ }
schedule_work(&ctrl->work_connect);
return;
}
@@ -288,12 +296,15 @@ static void gamecube_ctrl_handle_report(struct gamecube_ctrl *ctrl, u8 *data)
input_report_key(dev, BTN_DPAD_RIGHT, btns & GC_BTN_DPAD_RIGHT);
input_report_key(dev, BTN_DPAD_DOWN, btns & GC_BTN_DPAD_DOWN);
input_report_key(dev, BTN_DPAD_UP, btns & GC_BTN_DPAD_UP);
- input_report_abs(dev, ABS_X, data[3]);
- input_report_abs(dev, ABS_Y, 255 - data[4]);
- input_report_abs(dev, ABS_RX, data[5]);
- input_report_abs(dev, ABS_RY, 255 - data[6]);
- input_report_abs(dev, ABS_Z, data[7]);
- input_report_abs(dev, ABS_RZ, data[8]);
+ for (i = 0; i < 6; i++) {
+ u8 a, b, v = data[3 + i];
+ a = ctrl->axis_min[i] = min(ctrl->axis_min[i], v);
+ b = ctrl->axis_max[i] = max(ctrl->axis_max[i], v);
+ v = 255U * (v - a) / (b - a);
+ if (gamecube_axes[i] == ABS_Y || gamecube_axes[i] == ABS_RY)
+ v = 255U - v;
+ input_report_abs(dev, gamecube_axes[i], v);
+ }
input_sync(dev);
unlock:
--
2.26.2
next prev parent reply other threads:[~2020-05-12 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 8:46 [PATCH v2 1/4] HID: gamecube-adapter: add nintendo gamecube adapter François-Xavier Carton
2020-05-12 8:46 ` [PATCH v2 2/4] HID: gamecube-adapter: add rumble support François-Xavier Carton
2020-06-19 7:15 ` Jiri Kosina
2020-07-21 8:57 ` François-Xavier Carton
2020-05-12 8:46 ` François-Xavier Carton [this message]
2020-05-12 8:46 ` [PATCH v2 4/4] HID: gamecube-adapter: restore input after suspend François-Xavier Carton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512084616.32158-3-fx.carton91@gmail.com \
--to=fx.carton91@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=flibitijibibo@gmail.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).