From: Marco Felsch <m.felsch@pengutronix.de>
To: Fengping Yu <fengping.yu@mediatek.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v10 1/3] dt-bindings: Add keypad devicetree documentation
Date: Thu, 28 May 2020 11:24:33 +0200 [thread overview]
Message-ID: <20200528092433.gyrcsin4ottvuewo@pengutronix.de> (raw)
In-Reply-To: <20200528084143.36482-2-fengping.yu@mediatek.com>
On 20-05-28 16:41, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
...
> + mediatek,debounce-us:
> + description: Debounce interval in microseconds
> + maximum: 256000
Nit, I would mention that 16000 is the default value which is applied if
not given.
Appart of this feel free to add my:
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Regards,
Marco
next prev parent reply other threads:[~2020-05-28 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 8:41 [PATCH v11] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
[not found] ` <20200528084143.36482-2-fengping.yu@mediatek.com>
2020-05-28 9:24 ` Marco Felsch [this message]
[not found] ` <20200528084143.36482-3-fengping.yu@mediatek.com>
2020-05-28 9:26 ` [PATCH v10 2/3] drivers: input: keyboard: Add mtk keypad driver Marco Felsch
[not found] ` <20200528084143.36482-4-fengping.yu@mediatek.com>
2020-05-28 9:26 ` [PATCH v10 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528092433.gyrcsin4ottvuewo@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).