From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Johan Jonker <jbx6244@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property
Date: Thu, 28 May 2020 16:01:36 -0600 [thread overview]
Message-ID: <20200528220136.GA748777@bogus> (raw)
In-Reply-To: <4727344.YYj2SkWT1V@diego>
On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko Stübner wrote:
> Hi Dmitry,
>
> Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov:
> > Hi Johan,
> >
> > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote:
> > > A test with the command below gives this error:
> > >
> > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml:
> > > touchscreen@3e: reg:0:0: 56 was expected
> > >
> > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models
> > > was shipped with different addresses then the binding currently allows.
> > > Change the reg property that any address will pass.
> > >
> > > make ARCH=arm dtbs_check
> > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/touchscreen/
> > > edt-ft5x06.yaml
> > >
> > > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > > ---
> > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> > > index 383d64a91..baa8e8f7e 100644
> > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> > > @@ -42,7 +42,7 @@ properties:
> > > - focaltech,ft6236
> > >
> > > reg:
> > > - const: 0x38
> > > + maxItems: 1
> >
> > Should we have a list of valid addresses instead of allowing any
> > address? Controllers usually have only a couple of addresses that they
> > support.
>
> from what I've read, the fdt touchscreen controllers are just a generic
> cpu with device-specific (or better panel-specific) firmware, which seems
> to include the address as well - so it looks to be variable.
>
> But of course that is only 2nd hand knowledge for me ;-)
>
>
> But also, the i2c address is something you cannot really mess up,
> either it is correct and your touchscreen works, or it isn't and and
> adding entries to this list every time a new address variant pops up
> feels clumsy.
Is that an Ack?
I'm fine either way. It's really only useful if there's a single
address because with a list it could still be wrong just as any other
data like an interrupt number could be wrong.
Rob
next prev parent reply other threads:[~2020-05-28 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:33 [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property Johan Jonker
2020-05-20 17:13 ` Dmitry Torokhov
2020-05-20 18:41 ` Heiko Stübner
2020-05-28 22:01 ` Rob Herring [this message]
2020-05-28 22:02 ` Heiko Stübner
2020-05-29 17:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528220136.GA748777@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).