From: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
To: Siarhei Vishniakou <svv@google.com>
Cc: linux-input <linux-input@vger.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: Kasan crash in hid-steam
Date: Mon, 15 Jun 2020 19:41:49 +0200 [thread overview]
Message-ID: <20200615174149.GA38082@casa> (raw)
In-Reply-To: <CAKF84v05UjZg-7ZrVcwExk7Jkux=siR4Y8UnMt7KV0-9BrRfzg@mail.gmail.com>
On Mon, Jun 15, 2020 at 11:00:21AM -0500, Siarhei Vishniakou wrote:
> Thanks Rodrigo,
>
> I ran the test 50 times with your patch, and no crashes.
Great! Let me CC the linux-input maintainers, to see if they can commit
this.
> Tested-by: Siarhei Vishniakou <svv@google.com>
Signed-off-by: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
> Side question, is there any plan to support the beta bluetooth mode
> for this controller?
> Currently, the controller permanently stays in the lizard mode when
> connected via bluetooth.
Actually this driver doesn't even look at the bluetooth, it is in lizard
mode because that is the default when plugged in. IIRC, the BLE protocol is
also HID and quite similar to the wireless USB one, mainly the 'framing'
is different, so it shouldn't be too difficult to develop. But since
Valve deprecated this device a while ago I think this firmware will be on
beta forever, and I'm not particularly interested in that. Maybe in the
future if I lose the original wireless adaptor...
Regards.
--
Rodrigo Rivas Costa
next prev parent reply other threads:[~2020-06-15 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 0:07 Kasan crash in hid-steam Siarhei Vishniakou
2020-06-13 12:22 ` Rodrigo Rivas Costa
2020-06-15 16:00 ` Siarhei Vishniakou
2020-06-15 17:41 ` Rodrigo Rivas Costa [this message]
2020-06-16 9:08 ` Jiri Kosina
2020-06-16 16:44 ` [PATCH] HID: steam: fixes race in handling device list Rodrigo Rivas Costa
2020-06-19 7:22 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615174149.GA38082@casa \
--to=rodrigorivascosta@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=svv@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).