From: Pavel Machek <pavel@ucw.cz>
To: Fengping Yu <fengping.yu@mediatek.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/3] dt-bindings:Add vibrator devicetree documentation
Date: Tue, 16 Jun 2020 12:58:31 +0200 [thread overview]
Message-ID: <20200616105831.GJ1718@bug> (raw)
In-Reply-To: <20200615114203.116656-2-fengping.yu@mediatek.com>
On Mon 2020-06-15 19:42:02, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
>
> Add Mediatek regulator vibrator dt-bindings doc as yaml schema
>
> Signed-off-by: fengping.yu <fengping.yu@mediatek.com>
> ---
> .../bindings/input/regulator-vibrator.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/regulator-vibrator.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/regulator-vibrator.yaml b/Documentation/devicetree/bindings/input/regulator-vibrator.yaml
> new file mode 100644
> index 000000000000..6511a8a80aff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/regulator-vibrator.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +version: 1
> +
> +$id: http://devicetree.org/schemas/input/regulator-vibrator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek's regulator vibrator device tree bindings
> +
> +maintainer:
> + - Fengping Yu <fengping.yu@mediatek.com>
> +
> +description: |
> + Registers a regulator device as vibrator, where the on/off capability is controlled by a regulator.
Line length?
> +properties:
> + compatible:
> + const: "regulator-vibrator"
> +
> + vibr-supply:
> + description: Power supply to the vibrator.
> + refs:Documentation/devicetree/bindings/regulator/regulator.txt for details.
> +
> + max-volt:
> + description: The maximum voltage value supplied to the vibrator regulator.
> + The unit of the voltage is micro.
> +
should be -microvolt?
> + min-volt:
> + description: The minimum voltage value supplied to the vibrator regulator.
> + The unit of the voltage is micro.
> +
> + min-limit:
> + description: The minimum duration time in ms for vibrator, default is 15ms.
> + If user request smaller duration, the default value will be used
> + instead. The default value comes from the smallest unit that can
> + be sensored.
English?
Add -usec or something?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-06-16 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 11:42 [PATCH v1] Add vibrator driver support for Mediatek SoCs Fengping Yu
[not found] ` <20200615114203.116656-2-fengping.yu@mediatek.com>
2020-06-16 10:58 ` Pavel Machek [this message]
[not found] ` <20200615114203.116656-3-fengping.yu@mediatek.com>
2020-06-15 15:07 ` [PATCH v1 2/3] drivers: input: misc: Add mtk vibrator driver kernel test robot
2020-06-16 11:02 ` Pavel Machek
2020-06-16 11:03 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616105831.GJ1718@bug \
--to=pavel@ucw.cz \
--cc=catalin.marinas@arm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).