linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hutterer <peter.hutterer@who-t.net>
To: Harry Cutts <hcutts@chromium.org>
Cc: linux-input <linux-input@vger.kernel.org>,
	spang@chromium.org, Kenneth Albanowski <kenalba@google.com>,
	Jacques Pienaar <jpienaar@google.com>,
	Nikolai Kondrashov <spbnick@gmail.com>
Subject: Re: Graphics tablets getting INPUT_PROP_DIRECT incorrectly
Date: Wed, 24 Jun 2020 17:06:26 +1000	[thread overview]
Message-ID: <20200624070626.GA18108@koala> (raw)
In-Reply-To: <CA+jURctks30toWAipy-ozvwrh1CsQzZHgAuNRPHdrDY2woufMA@mail.gmail.com>

On Wed, Jun 17, 2020 at 02:39:47PM -0700, Harry Cutts wrote:
> Hi Kernel input people,
> 
> On Chrome OS, we've observed a couple of graphics tablets getting
> INPUT_PROP_DIRECT set despite them being traditional digitizers
> without screens. The two tablets we've seen this for are the Huion
> H610PRO (VID:PID 256c:006d) and the UGTABLET 10 inch PenTablet
> (28bd:0905). Reverting "HID: input: Set INPUT_PROP_-property for
> HID_UP_DIGITIZERS" (8473a93d1ba5385f63a128a285702ccc1d3ae2cc) fixes
> the Huinon, at least. (We didn't get a chance to test it with the
> UGTABLET.) Do we know if this is a shortcoming of that patch, are
> those tablets just describing themselves incorrectly in their HID
> descriptors? (in which case I guess we'd just have to add quirks for
> them)

fwiw, both huion and ugtablet are ones i know are regularly giving me
troubles in libinput because what they say they do and what they do isn't in
sync. HUION also re-uses usbids. 006d is a relatively new one I think, we
have at least 7 different devices with 0256c:006e in libwacom and need to
match on the name there, but with the Huion HS610 even that breaks - it uses
the same vid/pid *and* name of other devices despite having different
properties [1]. HS610, HS64 and your H610PRO all seem to use 000d, so...
yay?

I've CC'd Nikolai, he has much more kernel-level experience with these
devices than I do.

Cheers,
   Peter

[1] https://github.com/linuxwacom/libwacom/pull/235


  reply	other threads:[~2020-06-24  7:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 21:39 Graphics tablets getting INPUT_PROP_DIRECT incorrectly Harry Cutts
2020-06-24  7:06 ` Peter Hutterer [this message]
2020-06-24 11:27   ` Nikolai Kondrashov
2020-06-24 17:45     ` Michael Spang
2020-06-25 23:33       ` Peter Hutterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624070626.GA18108@koala \
    --to=peter.hutterer@who-t.net \
    --cc=hcutts@chromium.org \
    --cc=jpienaar@google.com \
    --cc=kenalba@google.com \
    --cc=linux-input@vger.kernel.org \
    --cc=spang@chromium.org \
    --cc=spbnick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).