* [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen
@ 2020-07-03 14:34 K900
2020-07-06 17:22 ` Lyude Paul
2020-07-07 1:13 ` Dmitry Torokhov
0 siblings, 2 replies; 4+ messages in thread
From: K900 @ 2020-07-03 14:34 UTC (permalink / raw)
Cc: Ilya Katsnelson, Dmitry Torokhov, Lyude Paul, Christophe JAILLET,
Gaurav Agrawal, Yussuf Khalil, Hans Verkuil, Dennis Kadioglu,
Benjamin Tissoires, Joe Perches, linux-input, linux-kernel
From: Ilya Katsnelson <me@0upti.me>
Tested on my own laptop, touchpad feels slightly more responsive with
this on, though it might just be placebo.
Signed-off-by: Ilya Katsnelson <me@0upti.me>
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 758dae8d6500..4b81b2d0fe06 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0093", /* T480 */
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
+ "LEN0099", /* X1 Extreme 1st */
"LEN009b", /* T580 */
"LEN200f", /* T450s */
"LEN2044", /* L470 */
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen
2020-07-03 14:34 [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen K900
@ 2020-07-06 17:22 ` Lyude Paul
2020-07-06 19:20 ` Ilya K
2020-07-07 1:13 ` Dmitry Torokhov
1 sibling, 1 reply; 4+ messages in thread
From: Lyude Paul @ 2020-07-06 17:22 UTC (permalink / raw)
To: K900
Cc: Dmitry Torokhov, Christophe JAILLET, Gaurav Agrawal,
Yussuf Khalil, Hans Verkuil, Dennis Kadioglu, Benjamin Tissoires,
Joe Perches, linux-input, linux-kernel
FWIW it's not placebo, it's why I always immediately notice when starting up a
new ThinkPad sample from lenovo if RMI4 is enabled or not :).
Anyway thank you for the patch, assuming you double-checked that clicking with
the clickpad still works (I made this mistake last time when trying to enable
this for the second generation X1 extreme):
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2020-07-03 at 17:34 +0300, K900 wrote:
> From: Ilya Katsnelson <me@0upti.me>
>
> Tested on my own laptop, touchpad feels slightly more responsive with
> this on, though it might just be placebo.
>
> Signed-off-by: Ilya Katsnelson <me@0upti.me>
> ---
> drivers/input/mouse/synaptics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 758dae8d6500..4b81b2d0fe06 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0093", /* T480 */
> "LEN0096", /* X280 */
> "LEN0097", /* X280 -> ALPS trackpoint */
> + "LEN0099", /* X1 Extreme 1st */
> "LEN009b", /* T580 */
> "LEN200f", /* T450s */
> "LEN2044", /* L470 */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen
2020-07-06 17:22 ` Lyude Paul
@ 2020-07-06 19:20 ` Ilya K
0 siblings, 0 replies; 4+ messages in thread
From: Ilya K @ 2020-07-06 19:20 UTC (permalink / raw)
To: lyude@redhat.com
Cc: Dmitry Torokhov, Christophe JAILLET, Gaurav Agrawal,
Yussuf Khalil, Hans Verkuil, Dennis Kadioglu, Benjamin Tissoires,
Joe Perches, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
(sorry for resending - the previous message got sent as HTML and bounced off the mailing list)
This actually made me retest it just now - it most definitely works, both by tapping and by actually clicking the button.
06.07.2020, 20:22, "Lyude Paul" <lyude@redhat.com>:
> FWIW it's not placebo, it's why I always immediately notice when starting up a
> new ThinkPad sample from lenovo if RMI4 is enabled or not :).
>
> Anyway thank you for the patch, assuming you double-checked that clicking with
> the clickpad still works (I made this mistake last time when trying to enable
> this for the second generation X1 extreme):
>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> On Fri, 2020-07-03 at 17:34 +0300, K900 wrote:
>> From: Ilya Katsnelson <me@0upti.me>
>>
>> Tested on my own laptop, touchpad feels slightly more responsive with
>> this on, though it might just be placebo.
>>
>> Signed-off-by: Ilya Katsnelson <me@0upti.me>
>> ---
>> drivers/input/mouse/synaptics.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>> index 758dae8d6500..4b81b2d0fe06 100644
>> --- a/drivers/input/mouse/synaptics.c
>> +++ b/drivers/input/mouse/synaptics.c
>> @@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>> "LEN0093", /* T480 */
>> "LEN0096", /* X280 */
>> "LEN0097", /* X280 -> ALPS trackpoint */
>> + "LEN0099", /* X1 Extreme 1st */
>> "LEN009b", /* T580 */
>> "LEN200f", /* T450s */
>> "LEN2044", /* L470 */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen
2020-07-03 14:34 [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen K900
2020-07-06 17:22 ` Lyude Paul
@ 2020-07-07 1:13 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2020-07-07 1:13 UTC (permalink / raw)
To: K900
Cc: Lyude Paul, Christophe JAILLET, Gaurav Agrawal, Yussuf Khalil,
Hans Verkuil, Dennis Kadioglu, Benjamin Tissoires, Joe Perches,
linux-input, linux-kernel
On Fri, Jul 03, 2020 at 05:34:55PM +0300, K900 wrote:
> From: Ilya Katsnelson <me@0upti.me>
>
> Tested on my own laptop, touchpad feels slightly more responsive with
> this on, though it might just be placebo.
>
> Signed-off-by: Ilya Katsnelson <me@0upti.me>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-07 1:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-03 14:34 [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen K900
2020-07-06 17:22 ` Lyude Paul
2020-07-06 19:20 ` Ilya K
2020-07-07 1:13 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).