From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A24C433E3 for ; Wed, 26 Aug 2020 19:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC93F22B40 for ; Wed, 26 Aug 2020 19:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598469441; bh=XTgW+tIJmaecdn2qfXIrRjOrub7hJlaxv5kPObiSC5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zehTtM4AlcbD8Hq0B++YfFWB90alCBcvWI3zERe9XuPfUJGVobwbYU5jSlIrpbVww G9iUVnbYvva5fssTa12zlg2SjIr/xRRDsmCdpS8FuGl9epCOwoUePyNOgLAdRk/EDu yQyya5g3PBv97yuozXhr09huK0vhTGiWhHDAw7VA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726947AbgHZTRQ (ORCPT ); Wed, 26 Aug 2020 15:17:16 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:41635 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbgHZTRP (ORCPT ); Wed, 26 Aug 2020 15:17:15 -0400 Received: by mail-ed1-f68.google.com with SMTP id c8so2737913edn.8; Wed, 26 Aug 2020 12:17:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8xGqYRG8ajCrh4u0eYU/fQCzra6d0D+pOOx7R79TMK0=; b=LWI7uyd2XbwmfWGIjp1icTngzDGk5eGORHVfPlgpgDbCa3STYxhv+C7FE0ehEm65TZ eHNb3N66avShzv1GJU0XyddvV6XAovXttfJlBEt0eSGGvoonv6osFqWK7SsvS7Eq5gkI nq15w+uQHx3p6VJs5i97cmbnEbRhBHANhG/ikAioy+kX9WXROR/gpm4LIhoLgim6sGjK eeEMoLdMj9lyWKG/TbrlEwYU50MRNNcPFnHtPlEhlbyONjtaE/U5ihjML8H/DsoR02Ff 1UBrNjMNYIy+eODjQppFcFbW2wHUkI+goGV0+P7aKvnNbkc4IkGBTAK7129UOznFc9/9 31Sw== X-Gm-Message-State: AOAM532cwLkdi+rn8cihtJFq6lE3PT5QZh1hr8bsiS0XhmVlKUMlT6oF nmgNx+VtZTteGXQH7y3TIVo= X-Google-Smtp-Source: ABdhPJyQDj5GAFJqp19VI5XGmXKh+NP7EjEyumm45r/4D70WWFdTs7PKal7GGssl9pz9tBPBd/x9qA== X-Received: by 2002:a05:6402:2031:: with SMTP id ay17mr15889987edb.46.1598469432489; Wed, 26 Aug 2020 12:17:12 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id r9sm2722466edq.44.2020.08.26.12.17.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Aug 2020 12:17:11 -0700 (PDT) Date: Wed, 26 Aug 2020 21:17:08 +0200 From: Krzysztof Kozlowski To: Andy Shevchenko Cc: Dmitry Torokhov , Hans de Goede , Linus Walleij , Bastien Nocera , Sangwon Jee , Eugen Hristev , "Gustavo A. R. Silva" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 01/24] Input: bcm-keypad - Simplify with dev_err_probe() Message-ID: <20200826191708.GA13466@kozik-lap> References: <20200826181706.11098-1-krzk@kernel.org> <20200826191217.GW1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200826191217.GW1891694@smile.fi.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Aug 26, 2020 at 10:12:17PM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 08:16:43PM +0200, Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > +++ b/drivers/input/keyboard/bcm-keypad.c > > @@ -379,11 +379,9 @@ static int bcm_kp_probe(struct platform_device *pdev) > > kp->clk = devm_clk_get(&pdev->dev, "peri_clk"); > > if (IS_ERR(kp->clk)) { > > error = PTR_ERR(kp->clk); > > - if (error != -ENOENT) { > > - if (error != -EPROBE_DEFER) > > - dev_err(&pdev->dev, "Failed to get clock\n"); > > - return error; > > - } > > + if (error != -ENOENT) > > + return dev_err_probe(&pdev->dev, error, "Failed to get clock\n"); > > + > > dev_dbg(&pdev->dev, > > "No clock specified. Assuming it's enabled\n"); > > Shouldn't be this rather switch to devm_clk_get_optional() + dev_err_probe? Indeed, it could be simplified even more. I'll send v2. Best regards, Krzysztof