From: Tao Ren <rentao.bupt@gmail.com>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-i2c@vger.kernel.org, joel@jms.id.au, andrew@aj.id.au,
benh@kernel.crashing.org, brendanhiggins@google.com,
dmitry.torokhov@gmail.com, robh+dt@kernel.org, wsa@kernel.org,
ryan_chen@aspeedtech.com
Subject: Re: [PATCH v2 3/5] i2c: aspeed: Mask IRQ status to relevant bits
Date: Tue, 8 Sep 2020 19:59:22 -0700 [thread overview]
Message-ID: <20200909025921.GA3449@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <20200908200101.64974-4-eajames@linux.ibm.com>
On Tue, Sep 08, 2020 at 03:00:59PM -0500, Eddie James wrote:
> Mask the IRQ status to only the bits that the driver checks. This
> prevents excessive driver warnings when operating in slave mode
> when additional bits are set that the driver doesn't handle.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
> ---
> drivers/i2c/busses/i2c-aspeed.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 31268074c422..2a388911038a 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -69,6 +69,7 @@
> * These share bit definitions, so use the same values for the enable &
> * status bits.
> */
> +#define ASPEED_I2CD_INTR_ALL 0xf000ffff
> #define ASPEED_I2CD_INTR_SDA_DL_TIMEOUT BIT(14)
> #define ASPEED_I2CD_INTR_BUS_RECOVER_DONE BIT(13)
> #define ASPEED_I2CD_INTR_SLAVE_MATCH BIT(7)
> @@ -604,6 +605,7 @@ static irqreturn_t aspeed_i2c_bus_irq(int irq, void *dev_id)
> writel(irq_received & ~ASPEED_I2CD_INTR_RX_DONE,
> bus->base + ASPEED_I2C_INTR_STS_REG);
> readl(bus->base + ASPEED_I2C_INTR_STS_REG);
> + irq_received &= ASPEED_I2CD_INTR_ALL;
> irq_remaining = irq_received;
>
> #if IS_ENABLED(CONFIG_I2C_SLAVE)
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-09-09 2:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 20:00 [PATCH v2 0/5] input: misc: Add IBM Operation Panel driver Eddie James
2020-09-08 20:00 ` [PATCH v2 1/5] dt-bindings: input: Add documentation for IBM Operation Panel Eddie James
2020-09-08 20:00 ` [PATCH v2 2/5] input: misc: Add IBM Operation Panel driver Eddie James
2020-09-08 20:40 ` wsa
2020-09-08 20:00 ` [PATCH v2 3/5] i2c: aspeed: Mask IRQ status to relevant bits Eddie James
2020-09-09 2:59 ` Tao Ren [this message]
2020-09-09 7:59 ` kernel test robot
2020-09-09 8:01 ` kernel test robot
2020-09-08 20:01 ` [PATCH v2 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device Eddie James
2020-09-09 6:56 ` Joel Stanley
2020-09-08 20:01 ` [PATCH v2 5/5] ARM: dts: Aspeed: Rainier: " Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909025921.GA3449@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).