From: Wolfram Sang <wsa@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
dmitry.torokhov@gmail.com, joel@jms.id.au, andrew@aj.id.au,
benh@kernel.crashing.org, brendanhiggins@google.com,
rentao.bupt@gmail.com, ryan_chen@aspeedtech.com
Subject: Re: [PATCH v3 3/5] i2c: aspeed: Mask IRQ status to relevant bits
Date: Thu, 10 Sep 2020 08:20:58 +0200 [thread overview]
Message-ID: <20200910062058.GC1031@ninjato> (raw)
In-Reply-To: <20200910061813.GB1031@ninjato>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On Thu, Sep 10, 2020 at 08:18:13AM +0200, Wolfram Sang wrote:
> On Wed, Sep 09, 2020 at 03:30:57PM -0500, Eddie James wrote:
> > Mask the IRQ status to only the bits that the driver checks. This
> > prevents excessive driver warnings when operating in slave mode
> > when additional bits are set that the driver doesn't handle.
> >
> > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
>
> I reconsidered and applied it now because this helps whenever slave mode
> is used. So, applied to for-current, thanks!
If someone could provide a Fixes tag, that would be welcome. For me, not
knowing the HW it doesn't look trivial to determine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-10 6:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:30 [PATCH v3 0/5] input: misc: Add IBM Operation Panel driver Eddie James
2020-09-09 20:30 ` [PATCH v3 1/5] dt-bindings: input: Add documentation for IBM Operation Panel Eddie James
2020-09-09 20:30 ` [PATCH v3 2/5] input: misc: Add IBM Operation Panel driver Eddie James
2020-09-10 6:13 ` Wolfram Sang
2020-09-13 17:17 ` Dmitry Torokhov
2020-09-09 20:30 ` [PATCH v3 3/5] i2c: aspeed: Mask IRQ status to relevant bits Eddie James
2020-09-10 6:18 ` Wolfram Sang
2020-09-10 6:20 ` Wolfram Sang [this message]
2020-09-10 9:00 ` Brendan Higgins
2020-09-10 13:55 ` Eddie James
2020-09-09 20:30 ` [PATCH v3 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device Eddie James
2020-09-10 2:41 ` Joel Stanley
2020-09-09 20:30 ` [PATCH v3 5/5] ARM: dts: Aspeed: Rainier: " Eddie James
2020-09-10 2:42 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910062058.GC1031@ninjato \
--to=wsa@kernel.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rentao.bupt@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).