linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: nick@shmanahar.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, digetx@gmail.com,
	andy.shevchenko@gmail.com, erosca@de.adit-jv.com,
	Andrew_Gabbasov@mentor.com
Subject: Re: [PATCH v4 1/1] Input: atmel_mxt_ts - implement I2C retries
Date: Sun, 13 Sep 2020 09:56:44 -0700	[thread overview]
Message-ID: <20200913165644.GF1665100@dtor-ws> (raw)
In-Reply-To: <20200912005521.26319-1-jiada_wang@mentor.com>

Hi Jiada,

On Sat, Sep 12, 2020 at 09:55:21AM +0900, Jiada Wang wrote:
> From: Nick Dyer <nick.dyer@itdev.co.uk>
> 
> Some maXTouch chips (eg mXT1386) will not respond on the first I2C request
> when they are in a sleep state. It must be retried after a delay for the
> chip to wake up.

Do we know when the chip is in sleep state? Can we do a quick I2C
transaction in this case instead of adding retry logic to everything? Or
there is another benefit for having such retry logic?

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2020-09-13 16:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  0:55 [PATCH v4 1/1] Input: atmel_mxt_ts - implement I2C retries Jiada Wang
2020-09-13  8:43 ` Andy Shevchenko
2020-09-13 12:57   ` Dmitry Osipenko
2020-09-14 13:49     ` Andy Shevchenko
2020-09-14 15:26       ` Dmitry Osipenko
2020-09-14 15:50         ` Andy Shevchenko
2020-09-14 16:28           ` Dmitry Osipenko
2020-09-13 16:56 ` Dmitry Torokhov [this message]
2020-09-14 17:29   ` Dmitry Osipenko
2020-09-14 19:33     ` Dmitry Torokhov
2020-09-14 19:36       ` Dmitry Torokhov
2020-09-14 21:33         ` Dmitry Osipenko
2020-09-14 22:32           ` Dmitry Torokhov
2020-09-15  1:13             ` Rob Herring
2020-09-15 15:55           ` Wang, Jiada
2020-09-15 17:40             ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200913165644.GF1665100@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=Andrew_Gabbasov@mentor.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=digetx@gmail.com \
    --cc=erosca@de.adit-jv.com \
    --cc=jiada_wang@mentor.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@shmanahar.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).