From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fengping Yu <fengping.yu@mediatek.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v18 2/3] drivers: input:keyboard: Add mtk keypad driver
Date: Sun, 13 Sep 2020 22:53:15 -0700 [thread overview]
Message-ID: <20200914055315.GJ1665100@dtor-ws> (raw)
In-Reply-To: <20200909072159.14888-3-fengping.yu@mediatek.com>
Hi Fengping,
On Wed, Sep 09, 2020 at 03:22:00PM +0800, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
>
> This patch adds matrix keypad support for Mediatek SoCs.
I am generally happy with the driver, however I do not believe this will
be the only Mediatek driver ever. Do you think we could rename it to
mt6779-keypad.c and use mt6779_keypad_ as prefix for function names?
Thanks!
--
Dmitry
prev parent reply other threads:[~2020-09-14 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200909072159.14888-1-fengping.yu@mediatek.com>
[not found] ` <20200909072159.14888-2-fengping.yu@mediatek.com>
2020-09-14 5:50 ` [PATCH v18 1/3] dt-bindings: Add bindings for Mediatek matrix keypad Dmitry Torokhov
[not found] ` <20200909072159.14888-3-fengping.yu@mediatek.com>
2020-09-14 5:53 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914055315.GJ1665100@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).