From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vincent Huang <vincent.huang@tw.synaptics.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Duggan <aduggan@synaptics.com>
Subject: Re: [PATCH] Input: trackpoint - add new trackpoint variant IDs
Date: Sun, 13 Sep 2020 22:57:26 -0700 [thread overview]
Message-ID: <20200914055726.GK1665100@dtor-ws> (raw)
In-Reply-To: <20200909083632.12971-1-vincent.huang@tw.synaptics.com>
Hi Vincent,
On Wed, Sep 09, 2020 at 04:36:32PM +0800, Vincent Huang wrote:
> Add trackpoint variant IDs to allow supported control
> on Synaptics trackpoints
>
> Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com>
> ---
> drivers/input/mouse/trackpoint.c | 2 ++
> drivers/input/mouse/trackpoint.h | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
> index 3eefee2ee2a1..c54d2f9e1c4a 100644
> --- a/drivers/input/mouse/trackpoint.c
> +++ b/drivers/input/mouse/trackpoint.c
> @@ -21,6 +21,8 @@ static const char * const trackpoint_variants[] = {
> [TP_VARIANT_ALPS] = "ALPS",
> [TP_VARIANT_ELAN] = "Elan",
> [TP_VARIANT_NXP] = "NXP",
> + [TP_VARIANT_JYT_SYNAPTICS] = "JYT_SYNAPTICS",
> + [TP_VARIANT_SYNAPTICS] = "SYNAPTICS",
Do these need to be capitalized? This is simply used in log messages, so
nicer formatted strings can be used.
Thanks.
--
Dmitry
prev parent reply other threads:[~2020-09-14 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 8:36 [PATCH] Input: trackpoint - add new trackpoint variant IDs Vincent Huang
2020-09-14 5:57 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914055726.GK1665100@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).