linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dmitry.torokhov@gmail.com
To: Kenny Levinsen <kl@kl.wtf>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: evdev - per-client waitgroups
Date: Mon, 5 Oct 2020 16:35:00 -0700	[thread overview]
Message-ID: <20201005233500.GM1009802@dtor-ws> (raw)
In-Reply-To: <20200429184126.2155-1-kl@kl.wtf>

Hi Kenny,

On Wed, Apr 29, 2020 at 08:41:26PM +0200, Kenny Levinsen wrote:
> All evdev clients share a common waitgroup. On new input events, this
> waitgroup is woken once for every client that did not filter the events,

I am having trouble parsing the changelog (I think I agree with the
change itself).  Did you mean to say "this waitqueue wakes up every
client, even ones that requested to filter out events that are being
delivered, leading to duplicated and unwanted wakeups"?

> leading to duplicated and unwanted wakeups.
> 
> Split the shared waitgroup into per-client waitgroups for more
> fine-grained wakeups.
> 

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2020-10-05 23:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 18:41 [PATCH] Input: evdev - per-client waitgroups Kenny Levinsen
2020-05-29 14:36 ` kl
2020-10-05 23:35 ` dmitry.torokhov [this message]
2020-10-06  9:15 ` kl
2020-10-07  1:35   ` dmitry.torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005233500.GM1009802@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=kl@kl.wtf \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).